Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3315)

Unified Diff: chrome/browser/resources/extensions/extension_options_overlay.js

Issue 484033003: Open embedded extension options from the extension action context menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix missed cases in refactor - setting optionsShown_ in onclose, scrolling only in the context menu… Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/extensions/extension_list.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/extensions/extension_options_overlay.js
diff --git a/chrome/browser/resources/extensions/extension_options_overlay.js b/chrome/browser/resources/extensions/extension_options_overlay.js
index b9614f374a1e2defcd7520d5ff1c772f1fa44ef7..e51e1fe34b664cb5b620fe0f09dc006ede6ca026 100644
--- a/chrome/browser/resources/extensions/extension_options_overlay.js
+++ b/chrome/browser/resources/extensions/extension_options_overlay.js
@@ -55,6 +55,9 @@ cr.define('extensions', function() {
$('extension-options-overlay-guest').removeChild(extensionoptions);
$('extension-options-overlay-icon').removeAttribute('src');
+
+ // Remove the options query string.
+ uber.replaceState({}, '');
},
/**
@@ -94,7 +97,7 @@ cr.define('extensions', function() {
extensionoptions.setDeferAutoSize(true);
extensionoptions.onclose = function() {
- this.handleDismiss_();
+ cr.dispatchSimpleEvent($('overlay'), 'cancelOverlay');
}.bind(this);
// Resize the overlay if the <extensionoptions> changes size.
« no previous file with comments | « chrome/browser/resources/extensions/extension_list.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698