chrome/browser/resources/extensions/extension_options_overlay.js - Issue 484033003: Open embedded extension options from the extension action context menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_options_overlay.js

Issue 484033003: Open embedded extension options from the extension action context menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactor opening the overlay, replace state using uber utils Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/extensions/extension_options_overlay.js

diff --git a/chrome/browser/resources/extensions/extension_options_overlay.js b/chrome/browser/resources/extensions/extension_options_overlay.js

index b9614f374a1e2defcd7520d5ff1c772f1fa44ef7..6d759c99e9011f6ff9c87f5af1fd004e18229c3c 100644

--- a/chrome/browser/resources/extensions/extension_options_overlay.js

+++ b/chrome/browser/resources/extensions/extension_options_overlay.js

@@ -55,6 +55,9 @@ cr.define('extensions', function() {

$('extension-options-overlay-guest').removeChild(extensionoptions);

$('extension-options-overlay-icon').removeAttribute('src');

+ // Remove the options query string.

+ uber.replaceState({}, '');

/**

« chrome/browser/resources/extensions/extension_list.js ('K') | « chrome/browser/resources/extensions/extension_list.js ('k') | no next file » | no next file with comments »