Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5853)

Unified Diff: chrome/browser/ui/chrome_pages.cc

Issue 484033003: Open embedded extension options from the extension action context menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix some bugs Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/chrome_pages.cc
diff --git a/chrome/browser/ui/chrome_pages.cc b/chrome/browser/ui/chrome_pages.cc
index 4cc02c0c9aa28acd704f42139076c0dbe8a70204..362e86b9a1e6eccd1b1f0488b794e65213326986 100644
--- a/chrome/browser/ui/chrome_pages.cc
+++ b/chrome/browser/ui/chrome_pages.cc
@@ -160,6 +160,21 @@ void ShowExtensions(Browser* browser,
ShowSingletonTabOverwritingNTP(browser, params);
}
+void ShowExtensionOptions(Browser* browser,
+ const std::string& extension_id) {
+ NavigateParams params(
+ GetSingletonTabNavigateParams(browser, GURL(kChromeUIExtensionsURL)));
+ params.path_behavior = NavigateParams::IGNORE_AND_NAVIGATE;
+ if (!extension_id.empty()) {
+ GURL::Replacements replacements;
+ std::string query("options=");
+ query += extension_id;
+ replacements.SetQueryStr(query);
+ params.url = params.url.ReplaceComponents(replacements);
+ }
+ ShowSingletonTabOverwritingNTP(browser, params);
+}
+
void ShowConflicts(Browser* browser) {
#if defined(OS_WIN)
EnumerateModulesModel* model = EnumerateModulesModel::GetInstance();
« chrome/browser/extensions/extension_context_menu_model.cc ('K') | « chrome/browser/ui/chrome_pages.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698