Open embedded extension options from the extension action context menu

chrome/browser/extensions/extension_context_menu_model.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_context_menu_model.h"
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/extensions/active_script_controller.h"
@@ skipping 15 matching lines @@
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/context_menu_params.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/management_policy.h"
 #include "extensions/browser/uninstall_reason.h"
 #include "extensions/common/extension.h"
+#include "extensions/common/feature_switch.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 using content::OpenURLParams;
 using content::Referrer;
 using content::WebContents;
 using extensions::Extension;
 using extensions::MenuItem;
 using extensions::MenuManager;
@@ skipping 122 matching lines @@
     case ALWAYS_RUN: {
       WebContents* web_contents = GetActiveWebContents();
       if (web_contents) {
         extensions::ActiveScriptController::GetForWebContents(web_contents)
             ->AlwaysRunOnVisibleOrigin(extension);
       }
       break;
     }
     case CONFIGURE:
       DCHECK(!extensions::ManifestURL::GetOptionsPage(extension).is_empty());
-      extensions::ExtensionTabUtil::OpenOptionsPage(extension, browser_);
+      if (extensions::FeatureSwitch::embedded_extension_options()->IsEnabled())
+        chrome::ShowExtensionOptions(browser_, extension->id());

[Devlin, 2014/08/19 17:39:07]

will look at this more later, but first off, why not just put the check for how
to (and implementation to) open the options page in
ExtensionTabUtil::OpenOptionsPage()?  Are there going to be times when we want
to show the legacy page?

[ericzeng, 2014/08/19 18:25:39]

That's a good idea; I just did it this way because I was using the extension
highlighting when you click the 'manage' context menu option as an example. 

+      else
+        extensions::ExtensionTabUtil::OpenOptionsPage(extension, browser_);
       break;
     case HIDE: {
       extensions::ExtensionActionAPI::SetBrowserActionVisibility(
           extensions::ExtensionPrefs::Get(profile_), extension->id(), false);
       break;
     }
     case UNINSTALL: {
       AddRef();  // Balanced in Accepted() and Canceled()
       extension_uninstall_dialog_.reset(
           extensions::ExtensionUninstallDialog::Create(
@@ skipping 96 matching lines @@
   extension_items_count_ = 0;
   extension_items_->AppendExtensionItems(MenuItem::ExtensionKey(extension_id_),
                                          base::string16(),
                                          &extension_items_count_,
                                          true);  // is_action_menu
 }
 
 content::WebContents* ExtensionContextMenuModel::GetActiveWebContents() const {
   return browser_->tab_strip_model()->GetActiveWebContents();
 }