Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Issue 483963002: Revert 290384 "Revert 289433 "Refactor pooling logic into a help..." (Closed)

Created:
6 years, 4 months ago by viettrungluu
Modified:
6 years, 4 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 290384 "Revert 289433 "Refactor pooling logic into a help..." Oops, reverted the original land, not the re-land. > Revert 289433 "Refactor pooling logic into a helper method" > > (Test-only?) leaks (see bug). The lsan suppressions file tells me to > revert, not suppress. > > BUG=404833 > > > Refactor pooling logic into a helper method > > Disable pooling when there are cert errors. > > Disable pooling when pinning does not match for the new host. > > > > BUG=398925 > > > > Review URL: https://codereview.chromium.org/425803014 > > TBR=rch@chromium.org > > Review URL: https://codereview.chromium.org/483043002 TBR=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -55 lines) Patch
M trunk/src/net/http/http_network_session.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/net/quic/quic_client_session.h View 3 chunks +3 lines, -0 lines 0 comments Download
M trunk/src/net/quic/quic_client_session.cc View 5 chunks +6 lines, -22 lines 0 comments Download
M trunk/src/net/quic/quic_client_session_test.cc View 7 chunks +54 lines, -10 lines 0 comments Download
M trunk/src/net/quic/quic_http_stream_test.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M trunk/src/net/quic/quic_stream_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/net/quic/quic_stream_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/quic/quic_stream_factory_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/net/socket/ssl_client_socket_pool_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/net/spdy/spdy_session.h View 4 chunks +11 lines, -0 lines 0 comments Download
M trunk/src/net/spdy/spdy_session.cc View 4 chunks +43 lines, -12 lines 0 comments Download
M trunk/src/net/spdy/spdy_session_pool.h View 3 chunks +4 lines, -0 lines 0 comments Download
M trunk/src/net/spdy/spdy_session_pool.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M trunk/src/net/spdy/spdy_session_unittest.cc View 4 chunks +107 lines, -3 lines 0 comments Download
M trunk/src/net/spdy/spdy_test_utils.h View 2 chunks +18 lines, -0 lines 0 comments Download
M trunk/src/net/spdy/spdy_test_utils.cc View 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
6 years, 4 months ago (2014-08-18 22:44:43 UTC) #1
viettrungluu
6 years, 4 months ago (2014-08-18 22:45:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r290385.

Powered by Google App Engine
This is Rietveld 408576698