Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: chrome/browser/sync/profile_sync_service.h

Issue 483883003: [Sync] Fix backup/rollback tests race conditions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service.h
diff --git a/chrome/browser/sync/profile_sync_service.h b/chrome/browser/sync/profile_sync_service.h
index 4c99c4d48b662037a3de66a58d21b33ce53fd907..ed483a9cabc9e286e6280a2014b63c714788b9f6 100644
--- a/chrome/browser/sync/profile_sync_service.h
+++ b/chrome/browser/sync/profile_sync_service.h
@@ -20,6 +20,7 @@
#include "base/strings/string16.h"
#include "base/time/time.h"
#include "base/timer/timer.h"
+#include "chrome/browser/browsing_data/browsing_data_remover.h"
#include "chrome/browser/sync/backend_unrecoverable_error_handler.h"
#include "chrome/browser/sync/backup_rollback_controller.h"
#include "chrome/browser/sync/glue/local_device_info_provider.h"
@@ -775,8 +776,12 @@ class ProfileSyncService : public ProfileSyncServiceBase,
return backend_mode_;
}
- void SetClearingBrowseringDataForTesting(
- base::Callback<void(Profile*, base::Time, base::Time)> c);
+ // Helpers for testing rollback.
+ void SetBrowsingDataRemoverObserverForTesting(
+ BrowsingDataRemover::Observer* observer);
+ void SetClearingBrowseringDataForTesting(base::Callback<
+ void(BrowsingDataRemover::Observer*, Profile*, base::Time, base::Time)>
+ c);
// Return the base URL of the Sync Server.
static GURL GetSyncServiceURL(const base::CommandLine& command_line);
@@ -1149,12 +1154,16 @@ class ProfileSyncService : public ProfileSyncServiceBase,
base::Time backup_start_time_;
- base::Callback<void(Profile*, base::Time, base::Time)> clear_browsing_data_;
+ base::Callback<
+ void(BrowsingDataRemover::Observer*, Profile*, base::Time, base::Time)>
+ clear_browsing_data_;
// Last time when pre-sync data was saved. NULL pointer means backup data
// state is unknown. If time value is null, backup data doesn't exist.
scoped_ptr<base::Time> last_backup_time_;
+ BrowsingDataRemover::Observer* browsing_data_remover_observer_;
+
DISALLOW_COPY_AND_ASSIGN(ProfileSyncService);
};

Powered by Google App Engine
This is Rietveld 408576698