Issue 483843004: HTTP2 draft 13: support unknown frame types and settings types as extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 483843004: HTTP2 draft 13: support unknown frame types and settings types as extensions. (Closed)

Created:
6 years, 4 months ago by Bence

Modified:
6 years, 4 months ago

Reviewers:
Johnny

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@merge_1

Project:
chromium

Visibility:
Public.

More Reviews

Description

HTTP2 draft 13: support unknown frame types and settings types as extensions. This lands server change 70895882 by mlavan. BUG=400336 This CL is not meant to be commited, only reviewed. It is commited together with other CLs on https://crrev.com/485833002.

Patch Set 1 #

Patch Set 2 : Add mock OnUnknownFrame to SpdyFramerVisitor in spdy_interface_test. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+230 lines, -27 lines)			Patch
M	net/quic/quic_headers_stream.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/quic/quic_headers_stream_test.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/spdy/buffered_spdy_framer.h	View		3 chunks	+8 lines, -1 line	0 comments	Download
M	net/spdy/buffered_spdy_framer.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/spdy/buffered_spdy_framer_unittest.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	net/spdy/mock_spdy_framer_visitor.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/spdy/spdy_framer.h	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	net/spdy/spdy_framer.cc	View		5 chunks	+35 lines, -11 lines	0 comments	Download
M	net/spdy/spdy_framer_test.cc	View		8 chunks	+103 lines, -9 lines	0 comments	Download
M	net/spdy/spdy_protocol.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_protocol.cc	View		2 chunks	+9 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_session.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_session.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_session_unittest.cc	View		1 chunk	+27 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_test_util_common.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/tools/flip_server/spdy_interface.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/tools/flip_server/spdy_interface.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/tools/flip_server/spdy_interface_test.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages