Issue 483843003: Remove unnecessary NodeFilterCondition.cpp file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 483843003: Remove unnecessary NodeFilterCondition.cpp file (Closed)

Created:
6 years, 4 months ago by Inactive

Modified:
6 years, 4 months ago

Reviewers:
adamk, rwlbuis

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Remove unnecessary NodeFilterCondition.cpp file Remove unnecessary NodeFilterCondition.cpp file. It only contains the implementation for acceptNode() virtual function but this one is marked as pure virtual in the header. R=rob.buis@samsung.com, adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180494

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -38 lines)			Patch
	M	Source/core/core.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
	D	Source/core/dom/NodeFilterCondition.cpp	View		1 chunk	+0 lines, -37 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/483843003/1

6 years, 4 months ago (2014-08-18 20:16:59 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 4 months ago (2014-08-18 20:28:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as 180494