sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart - Issue 48383003: Support checking of malbounded types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart

Issue 48383003: Support checking of malbounded types. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart ('k') | sdk/lib/_internal/compiler/implementation/resolution/members.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart

index 5644edba756093572b1f14daff97913227b01679..0a578efb9a83e2ed71e0451e0f72c9ce93f718b8 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart

@@ -235,9 +235,10 @@ class TypeTestEmitter extends CodeEmitterHelper {

Map<FunctionType, bool> getFunctionTypeChecksOn(DartType type) {

Map<FunctionType, bool> functionTypeMap = new Map<FunctionType, bool>();

for (FunctionType functionType in checkedFunctionTypes) {

- if (compiler.types.isSubtype(type, functionType)) {

+ int maybeSubtype = compiler.types.computeSubtypeRelation(type, functionType);

+ if (maybeSubtype == Types.IS_SUBTYPE) {

functionTypeMap[functionType] = true;

- } else if (compiler.types.isPotentialSubtype(type, functionType)) {

+ } else if (maybeSubtype == Types.MAYBE_SUBTYPE) {

functionTypeMap[functionType] = false;

}