Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 483813002: DevTools: Add workerShadowPageLoaded method to shared/service worker clients for further plumbing i… (Closed)

Created:
6 years, 4 months ago by vsevik
Modified:
6 years, 4 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

DevTools: Add workerShadowPageLoaded method to shared/service worker clients for further plumbing into the browser. This method is going to be used as a new signal for opening worker frontend when 'debug on start' option is enabled. BUG=404355 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180480

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M public/web/WebServiceWorkerContextClient.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M public/web/WebSharedWorkerClient.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vsevik
PTAL
6 years, 4 months ago (2014-08-18 16:04:46 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/483813002/diff/1/public/web/WebServiceWorkerContextClient.h File public/web/WebServiceWorkerContextClient.h (right): https://codereview.chromium.org/483813002/diff/1/public/web/WebServiceWorkerContextClient.h#newcode75 public/web/WebServiceWorkerContextClient.h:75: // start a worker thread. Let add more ...
6 years, 4 months ago (2014-08-18 16:14:45 UTC) #2
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 4 months ago (2014-08-18 16:32:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/483813002/20001
6 years, 4 months ago (2014-08-18 16:33:19 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-18 17:40:33 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 18:17:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180480

Powered by Google App Engine
This is Rietveld 408576698