content/renderer/render_view_impl.h - Issue 483773002: PlzNavigate: implement CommitNavigation on the browser side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 483773002: PlzNavigate: implement CommitNavigation on the browser side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: NavigationRequest has ownership of NavigationParams Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index effecb22c4862e777ed397e855ee36b192ca800a..6ebe2980bafa53b8f7de80dab662ea45d7950393 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -26,8 +26,10 @@

#include "content/common/content_export.h"

#include "content/common/drag_event_source_info.h"

#include "content/common/edit_command.h"

+#include "content/common/frame_message_enums.h"

#include "content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h"

#include "content/common/navigation_gesture.h"

+#include "content/common/navigation_params.h"

#include "content/common/view_message_enums.h"

#include "content/public/common/page_zoom.h"

#include "content/public/common/referrer.h"

@@ -633,7 +635,7 @@ class CONTENT_EXPORT RenderViewImpl

void didUpdateCurrentHistoryItem(blink::WebLocalFrame* frame);

void didChangeScrollOffset(blink::WebLocalFrame* frame);

- static bool IsReload(const FrameMsg_Navigate_Params& params);

+ static bool IsReload(FrameMsg_Navigate_Type::Value navigation_type);

static Referrer GetReferrerFromRequest(

blink::WebFrame* frame,

« content/common/navigation_params.cc ('K') | « content/renderer/render_view_browsertest.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »