Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 483753003: Add temporary hack compatible with old delete behavior so we can roll into blink. We'll need to upd… (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add temporary hack compatible with old delete behavior so we can roll into blink. We'll need to update the broken test. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23171

Patch Set 1 #

Patch Set 2 : Handle global object properly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/objects.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-18 16:44:31 UTC) #1
Jakob Kummerow
lgtm
6 years, 4 months ago (2014-08-18 16:45:19 UTC) #2
Toon Verwaest
6 years, 4 months ago (2014-08-18 16:52:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 23171 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698