Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 483703004: Use a qualified path for grit/net_resources.h (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, jochen+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use a qualified path for grit/net_resources.h BUG=401588 R=thestig@chromium.org TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290382

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : gnnnnn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M build/grit_target.gypi View 1 chunk +3 lines, -2 lines 0 comments Download
M content/shell/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/shell_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/base/net_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/net.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
6 years, 4 months ago (2014-08-18 17:20:53 UTC) #1
Lei Zhang
lgtm
6 years, 4 months ago (2014-08-18 22:28:59 UTC) #2
Nico
6 years, 4 months ago (2014-08-18 22:36:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as 290382 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698