Issue 483703002: Supervised users: Use custodian avatar image(s) in the block interstitial if they're available.

Issue 483703002: Supervised users: Use custodian avatar image(s) in the block interstitial if they're available. (Closed)

Created:
6 years, 4 months ago by Marc Treib

Modified:
6 years, 4 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, pam+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Supervised users: Use custodian avatar image(s) in the block interstitial if they're available. BUG=404671 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290523

Patch Set 2 : review comments #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -9 lines)			Patch
M	chrome/browser/resources/supervised_user_block_interstitial.css	View		2 chunks	+15 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/supervised_user_block_interstitial.html	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/supervised_user_block_interstitial.js	View		3 chunks	+25 lines, -0 lines	0 comments	Download
M	chrome/browser/supervised_user/supervised_user_interstitial.cc	View	1	3 chunks	+44 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

LGTM w/ nits, but add a bug number pls? Also, do you have screenshots what ...

6 years, 4 months ago (2014-08-18 15:57:31 UTC) #2

Marc Treib

Bug added; screenshot on the bug. https://codereview.chromium.org/483703002/diff/1/chrome/browser/supervised_user/supervised_user_interstitial.cc File chrome/browser/supervised_user/supervised_user_interstitial.cc (right): https://codereview.chromium.org/483703002/diff/1/chrome/browser/supervised_user/supervised_user_interstitial.cc#newcode43 chrome/browser/supervised_user/supervised_user_interstitial.cc:43: const std::string& base_url, ...

6 years, 4 months ago (2014-08-18 16:35:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/483703002/20001

6 years, 4 months ago (2014-08-19 07:58:44 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-19 09:17:57 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (20001) as 290523

Expand Messages | Collapse Messages