Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 483683002: DevTools: fix a few inspector/audits tests (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: fix a few inspector/audits tests The patch fixes inspector/audits/audits-panel-noimages-functional.html and inspector/audits/audits-panel-functional.html BUG=364088, 357079 R=apavlov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180448

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -21 lines) Patch
M LayoutTests/FlakyTests View 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/TestExpectations View 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/inspector/audits/audits-panel-functional.html View 1 chunk +8 lines, -4 lines 0 comments Download
M LayoutTests/inspector/audits/audits-panel-noimages-functional.html View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
lushnikov
ptal
6 years, 4 months ago (2014-08-18 10:11:31 UTC) #1
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 4 months ago (2014-08-18 10:12:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/483683002/1
6 years, 4 months ago (2014-08-18 10:13:12 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-18 10:13:12 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-18 10:13:13 UTC) #5
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 4 months ago (2014-08-18 10:40:58 UTC) #6
apavlov
lgtm
6 years, 4 months ago (2014-08-18 10:40:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/483683002/1
6 years, 4 months ago (2014-08-18 10:42:17 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 11:47:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (1) as 180448

Powered by Google App Engine
This is Rietveld 408576698