Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 483643004: Make YCM ignore unknown warning options. (Closed)

Created:
6 years, 4 months ago by dzhioev (left Google)
Modified:
6 years, 4 months ago
Reviewers:
eroman
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Make YCM ignore unknown warning options. After r290361, '-Wno-undefined-bool-conversion' and '-Wno-tautological-undefined-compare' are used to build Debug Chromium with Clang. The problem is these options were introduced in Clang 3.5, and latest YCM uses Clang 3.4. This caused compilation error "unknown warning option" in YCM for every "*.cc" file. Fixed by adding '-Wno-unknown-warning-option' to YCM compilation flags. BUG=none TEST=manually NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/vim/chromium.ycm_extra_conf.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dzhioev (left Google)
Hi Eric, please review fix for YCM config.
6 years, 4 months ago (2014-08-19 19:13:25 UTC) #1
eroman
lgtm
6 years, 4 months ago (2014-08-19 19:15:04 UTC) #2
dzhioev (left Google)
The CQ bit was checked by dzhioev@chromium.org
6 years, 4 months ago (2014-08-19 19:31:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/483643004/1
6 years, 4 months ago (2014-08-19 19:32:07 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 19:43:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 290635

Powered by Google App Engine
This is Rietveld 408576698