Issue 48363002: DevTools: Improve CommandLineAPI's getEventListeners result.

Issue 48363002: DevTools: Improve CommandLineAPI's getEventListeners result. (Closed)

Created:
7 years, 1 month ago by aandrey

Modified:
7 years, 1 month ago

Reviewers:
caseq, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Improve CommandLineAPI's getEventListeners result. Expose "type" string and "remove()" function. BUG=309524 R=caseq, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160713

Patch Set 1 #

Total comments: 1

Patch Set 2 : removed try-catch #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -1 line)			Patch
M	LayoutTests/inspector/console/command-line-api-getEventListeners.html	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt	View	1	3 chunks	+23 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InjectedScriptSource.js	View	1	1 chunk	+17 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/48363002/diff/1/Source/core/inspector/InjectedScriptSource.js File Source/core/inspector/InjectedScriptSource.js (right): https://codereview.chromium.org/48363002/diff/1/Source/core/inspector/InjectedScriptSource.js#newcode1400 Source/core/inspector/InjectedScriptSource.js:1400: } catch (e) { why try / catch?

7 years, 1 month ago (2013-10-28 09:22:57 UTC) #2

aandrey

On 2013/10/28 09:22:57, pfeldman wrote: > lgtm > > https://codereview.chromium.org/48363002/diff/1/Source/core/inspector/InjectedScriptSource.js > File Source/core/inspector/InjectedScriptSource.js (right): > ...

7 years, 1 month ago (2013-10-28 09:24:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/48363002/70001

7 years, 1 month ago (2013-10-28 09:29:24 UTC) #4

Message was sent while issue was closed.

Change committed as 160713

Expand Messages | Collapse Messages