[ServiceWorker] Support other methods than GET and HEAD.

[ServiceWorker] Support other methods than GET and HEAD.

BUG=402387
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290247

[horo, 2014-08-18 06:07:04]

falken@
Could you please review?

[falken, 2014-08-18 06:31:46]

lgtm

https://codereview.chromium.org/483613004/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_request_handler.cc (left):

https://codereview.chromium.org/483613004/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_request_handler.cc:63: if
(!IsSchemeAndMethodSupportedForAppCache(request)) {
I was confused by this AppCache name. It was probably a mistake from
https://codereview.chromium.org/344493002

[horo, 2014-08-18 06:49:44]

https://codereview.chromium.org/483613004/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_request_handler.cc (left):

https://codereview.chromium.org/483613004/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_request_handler.cc:63: if
(!IsSchemeAndMethodSupportedForAppCache(request)) {
On 2014/08/18 06:31:46, falken wrote:
> I was confused by this AppCache name. It was probably a mistake from
> https://codereview.chromium.org/344493002

I think ServiceWorkerRequestHandler was initially created by copying
AppCacheRequestHandler.

[horo, 2014-08-18 06:49:48]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-08-18 06:50:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/horo@chromium.org/483613004/1

[horo, 2014-08-18 06:51:28]

On 2014/08/18 06:49:44, horo wrote:
>
https://codereview.chromium.org/483613004/diff/1/content/browser/service_work...
> File content/browser/service_worker/service_worker_request_handler.cc (left):
> 
>
https://codereview.chromium.org/483613004/diff/1/content/browser/service_work...
> content/browser/service_worker/service_worker_request_handler.cc:63: if
> (!IsSchemeAndMethodSupportedForAppCache(request)) {
> On 2014/08/18 06:31:46, falken wrote:
> > I was confused by this AppCache name. It was probably a mistake from
> > https://codereview.chromium.org/344493002
> 
> I think ServiceWorkerRequestHandler was initially created by copying
> AppCacheRequestHandler.

Ah, 344493002 introduced this mistake.

[commit-bot: I haz the power, 2014-08-18 08:35:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-18 08:56:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-18 08:56:30]

Try jobs failed on following builders:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[horo, 2014-08-18 11:57:47]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-08-18 11:58:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/horo@chromium.org/483613004/1

[commit-bot: I haz the power, 2014-08-18 13:17:57]

Committed patchset #1 (1) as 290247