Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 483603003: [ServiceWorker] Add WebServiceWorkerRequest::setBlob() to support body of FetchEvent (Closed)

Created:
6 years, 4 months ago by horo
Modified:
6 years, 4 months ago
Reviewers:
falken, tkent
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Add WebServiceWorkerRequest::setBlob() to support body of FetchEvent BUG=402387 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180430

Patch Set 1 #

Total comments: 7

Patch Set 2 : incorporated tkent's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M Source/platform/exported/WebServiceWorkerRequest.cpp View 1 3 chunks +13 lines, -0 lines 0 comments Download
M public/platform/WebServiceWorkerRequest.h View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
horo
falken@ Could you please review this?
6 years, 4 months ago (2014-08-18 03:10:52 UTC) #1
falken
lgtm
6 years, 4 months ago (2014-08-18 03:17:56 UTC) #2
horo
tkent@ Could you please review this?
6 years, 4 months ago (2014-08-18 05:19:51 UTC) #3
tkent
https://codereview.chromium.org/483603003/diff/1/Source/platform/exported/WebServiceWorkerRequest.cpp File Source/platform/exported/WebServiceWorkerRequest.cpp (right): https://codereview.chromium.org/483603003/diff/1/Source/platform/exported/WebServiceWorkerRequest.cpp#newcode6 Source/platform/exported/WebServiceWorkerRequest.cpp:6: #include "platform/blob/BlobData.h" Please follow #3 of http://www.chromium.org/blink/coding-style#TOC-include-Statements https://codereview.chromium.org/483603003/diff/1/Source/platform/exported/WebServiceWorkerRequest.cpp#newcode70 Source/platform/exported/WebServiceWorkerRequest.cpp:70: ...
6 years, 4 months ago (2014-08-18 05:28:55 UTC) #4
tkent
https://codereview.chromium.org/483603003/diff/1/Source/platform/exported/WebServiceWorkerRequest.cpp File Source/platform/exported/WebServiceWorkerRequest.cpp (right): https://codereview.chromium.org/483603003/diff/1/Source/platform/exported/WebServiceWorkerRequest.cpp#newcode6 Source/platform/exported/WebServiceWorkerRequest.cpp:6: #include "platform/blob/BlobData.h" On 2014/08/18 05:28:55, tkent wrote: > Please ...
6 years, 4 months ago (2014-08-18 05:29:47 UTC) #5
horo
https://codereview.chromium.org/483603003/diff/1/Source/platform/exported/WebServiceWorkerRequest.cpp File Source/platform/exported/WebServiceWorkerRequest.cpp (right): https://codereview.chromium.org/483603003/diff/1/Source/platform/exported/WebServiceWorkerRequest.cpp#newcode6 Source/platform/exported/WebServiceWorkerRequest.cpp:6: #include "platform/blob/BlobData.h" On 2014/08/18 05:29:47, tkent wrote: > On ...
6 years, 4 months ago (2014-08-18 05:41:40 UTC) #6
tkent
lgtm
6 years, 4 months ago (2014-08-18 05:43:42 UTC) #7
horo
The CQ bit was checked by horo@chromium.org
6 years, 4 months ago (2014-08-18 05:53:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/483603003/20001
6 years, 4 months ago (2014-08-18 05:53:08 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-18 06:53:22 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 07:33:02 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 180430

Powered by Google App Engine
This is Rietveld 408576698