Make git unittest_helpers only use setUp/tearDown.

Make git unittest_helpers only use setUp/tearDown.

This allows test cases based on unittest_helpers to run in parallel when
executed under expect_tests. This change shaves 4s off ./test.py in
infra currently (down from 15s) on my MacBook Pro (2.2 GHz i7, Late 2011).

R=vadimsh@chromium.org, agable@chromium.org
BUG=

Committed: https://chromium.googlesource.com/infra/testing/testing_support/+/26ba50e

[Vadim Sh., 2014-08-17 04:40:00]

lgtm

https://codereview.chromium.org/483553002/diff/20001/testing_support/git/unit...
File testing_support/git/unittest_helpers.py (right):

https://codereview.chromium.org/483553002/diff/20001/testing_support/git/unit...
testing_support/git/unittest_helpers.py:24: GitRepoSchemaTestBase into TestCase
classes which subclass this.
GitRepoSchemaTestBase?

https://codereview.chromium.org/483553002/diff/20001/testing_support/git/unit...
testing_support/git/unittest_helpers.py:45: self.r_schema =
GitRepoSchema(self.REPO_SCHEMA, self.getRepoContent)
is r_schema used outside of setUp here?

https://codereview.chromium.org/483553002/diff/20001/testing_support/git/unit...
testing_support/git/unittest_helpers.py:50: self.repo.nuke()
try:
  ...
finally:
  super(GitRepoTestBase, self).tearDown()

Or you 100% sure it won't blow up?

https://codereview.chromium.org/483553002/diff/20001/testing_support/git/unit...
testing_support/git/unittest_helpers.py:57: GitRepoReadWriteTestBase =
GitRepoTestBase
I assume you'll commit this, roll deps, get rid of deprecated names, remove them
here, roll deps again?

[iannucci, 2014-08-17 08:46:52]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2014-08-17 08:47:04]

https://codereview.chromium.org/483553002/diff/20001/testing_support/git/unit...
File testing_support/git/unittest_helpers.py (right):

https://codereview.chromium.org/483553002/diff/20001/testing_support/git/unit...
testing_support/git/unittest_helpers.py:24: GitRepoSchemaTestBase into TestCase
classes which subclass this.
On 2014/08/17 04:39:59, Vadim Sh. wrote:
> GitRepoSchemaTestBase?

Fixed this whole docstring

https://codereview.chromium.org/483553002/diff/20001/testing_support/git/unit...
testing_support/git/unittest_helpers.py:45: self.r_schema =
GitRepoSchema(self.REPO_SCHEMA, self.getRepoContent)
On 2014/08/17 04:39:59, Vadim Sh. wrote:
> is r_schema used outside of setUp here?

It can be/is accessed by the tests

https://codereview.chromium.org/483553002/diff/20001/testing_support/git/unit...
testing_support/git/unittest_helpers.py:50: self.repo.nuke()
On 2014/08/17 04:39:59, Vadim Sh. wrote:
> try:
>   ...
> finally:
>   super(GitRepoTestBase, self).tearDown()
> 
> Or you 100% sure it won't blow up?

Fair enough. I haven't seen it blow up in practice tho. changed to try/finally
:)

https://codereview.chromium.org/483553002/diff/20001/testing_support/git/unit...
testing_support/git/unittest_helpers.py:57: GitRepoReadWriteTestBase =
GitRepoTestBase
On 2014/08/17 04:39:59, Vadim Sh. wrote:
> I assume you'll commit this, roll deps, get rid of deprecated names, remove
them
> here, roll deps again?

yep

[iannucci, 2014-08-17 08:47:13]

Committed patchset #3 manually as 26ba50e (presubmit successful).