Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: content/browser/frame_host/render_frame_host_delegate.h

Issue 483523006: Check all settings when checking mic and camera access (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_delegate.h
diff --git a/content/browser/frame_host/render_frame_host_delegate.h b/content/browser/frame_host/render_frame_host_delegate.h
index 40af1dba20c272427e2dc4af89622628cd87094e..9a82374654da34f190f11ca2ddaaf1bb9a0b1b90 100644
--- a/content/browser/frame_host/render_frame_host_delegate.h
+++ b/content/browser/frame_host/render_frame_host_delegate.h
@@ -130,6 +130,13 @@ class CONTENT_EXPORT RenderFrameHostDelegate {
const MediaStreamRequest& request,
const MediaResponseCallback& callback);
+ // Checks if we have permissions to access the microphone based on policy and
+ // app permissions. Note that this does not check e.g. the content settings
+ // nor query the user.
+ virtual void AllowMicAccessBasedOnPolicyAndAppPermissions(
Charlie Reis 2014/08/25 18:35:44 nit: Calling this "AllowFoo" makes it sound like i
Henrik Grunell 2014/08/25 19:14:13 Agree. I think "Request..." implies query the user
Henrik Grunell 2014/08/26 16:56:32 Done.
+ const GURL& security_origin,
Charlie Reis 2014/08/25 18:35:44 Security origins can be a bit subtle to get right.
Henrik Grunell 2014/08/25 19:14:13 From https://code.google.com/p/chromium/codesearch
Charlie Reis 2014/08/25 20:30:10 Ok, sounds like there's an existing (presumably ve
+ const MediaAccessResponseCallback& callback);
+
// Get the accessibility mode for the WebContents that owns this frame.
virtual AccessibilityMode GetAccessibilityMode() const;

Powered by Google App Engine
This is Rietveld 408576698