Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 483513002: Fix windows compilation warning in es_parser_adts. (Closed)

Created:
6 years, 4 months ago by damienv1
Modified:
6 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix windows compilation warning in es_parser_adts. Export the mpeg2 ts EsParser base class so that NON_EXPORTED_BASE is not needed in EsParserH264 and EsParserAdts. BUG=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M media/formats/mp2t/es_parser.h View 2 chunks +2 lines, -1 line 0 comments Download
M media/formats/mp2t/es_parser_h264.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
damienv1
My mistake during https://codereview.chromium.org/399433003/ Not caught in the TryBots. Please review ASAP, thanks.
6 years, 4 months ago (2014-08-17 00:23:53 UTC) #1
damienv1
FYI: This is warning that was automatically reported to me. j:\chromiumtrunk\src\media\formats\mp2t\es_parser_adts.h(29) : error C2220: warn ...
6 years, 4 months ago (2014-08-17 00:26:23 UTC) #2
tommi (sloooow) - chröme
The CQ bit was checked by tommi@chromium.org
6 years, 4 months ago (2014-08-18 09:44:01 UTC) #3
tommi (sloooow) - chröme
lgtm
6 years, 4 months ago (2014-08-18 09:44:02 UTC) #4
tommi (sloooow) - chröme
On 2014/08/18 09:44:02, tommi wrote: > lgtm fyi - committing since the build is currently ...
6 years, 4 months ago (2014-08-18 09:44:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/damienv@chromium.org/483513002/1
6 years, 4 months ago (2014-08-18 09:44:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as 290231
6 years, 4 months ago (2014-08-18 09:53:20 UTC) #7
wolenetz
6 years, 4 months ago (2014-08-20 20:00:36 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698