expose generalized imagecache key

expose generalized imagecache key

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/04617139f7f715bdc05a32a58e65e3c208bccff4

[reed1, 2014-08-21 15:13:18]

still think I'll try inverting the specialization, to ask the client to subclass
Rec, thus allowing them to have different return types as well, but I think this
stage is worth landing as is.

[Stephen White, 2014-08-21 15:20:14]

drive-by comment: this looks like a great step forward, and I plan to
investigate reusing it for the ImageFilter cache as well.

[reed1, 2014-08-21 15:23:54]

On 2014/08/21 15:20:14, Stephen White wrote:
> drive-by comment: this looks like a great step forward, and I plan to
> investigate reusing it for the ImageFilter cache as well.

Very good to hear. Certain my hope for the next iteration is to allow the result
to be whatever (not just bitmap or mipmap), though perhaps in your case, this CL
is sufficient, if you just need a custom Key but area happy just receiving a
bitmap.

[mtklein, 2014-08-21 15:29:18]

lgtm

https://codereview.chromium.org/483493003/diff/1/src/core/SkBitmapCache.cpp
File src/core/SkBitmapCache.cpp (right):

https://codereview.chromium.org/483493003/diff/1/src/core/SkBitmapCache.cpp#n...
src/core/SkBitmapCache.cpp:25: struct GenWHKey : public SkScaledImageCache::Key
{
Might want to consider just CacheKey?  GenWHKey is a little confusing as a name
when the fields don't read "gen ID, width, height".

https://codereview.chromium.org/483493003/diff/1/src/core/SkBitmapCache.h
File src/core/SkBitmapCache.h (right):

https://codereview.chromium.org/483493003/diff/1/src/core/SkBitmapCache.h#new...
src/core/SkBitmapCache.h:41: static ID* FindAndLock(const SkBitmap& src,
SkMipMap const** result);
try const SkMipMap** (though I see this is preexisting)

[hal.canary, 2014-08-21 15:35:01]

https://codereview.chromium.org/483493003/diff/1/src/core/SkBitmapCache.h
File src/core/SkBitmapCache.h (right):

https://codereview.chromium.org/483493003/diff/1/src/core/SkBitmapCache.h#new...
src/core/SkBitmapCache.h:8: #ifndef SkScaledBitmapKey_DEFINED
Wrong define name

[reed1, 2014-08-21 15:58:11]

https://codereview.chromium.org/483493003/diff/1/src/core/SkBitmapCache.cpp
File src/core/SkBitmapCache.cpp (right):

https://codereview.chromium.org/483493003/diff/1/src/core/SkBitmapCache.cpp#n...
src/core/SkBitmapCache.cpp:25: struct GenWHKey : public SkScaledImageCache::Key
{
On 2014/08/21 15:29:18, mtklein wrote:
> Might want to consider just CacheKey?  GenWHKey is a little confusing as a
name
> when the fields don't read "gen ID, width, height".

Done.

https://codereview.chromium.org/483493003/diff/1/src/core/SkBitmapCache.h
File src/core/SkBitmapCache.h (right):

https://codereview.chromium.org/483493003/diff/1/src/core/SkBitmapCache.h#new...
src/core/SkBitmapCache.h:8: #ifndef SkScaledBitmapKey_DEFINED
On 2014/08/21 15:35:01, Hal Canary wrote:
> Wrong define name

Done.

https://codereview.chromium.org/483493003/diff/1/src/core/SkBitmapCache.h#new...
src/core/SkBitmapCache.h:41: static ID* FindAndLock(const SkBitmap& src,
SkMipMap const** result);
On 2014/08/21 15:29:18, mtklein wrote:
> try const SkMipMap** (though I see this is preexisting)

Done.

[qiankun, 2014-08-21 16:15:04]

https://codereview.chromium.org/483493003/diff/1/src/core/SkScaledImageCache.cpp
File src/core/SkScaledImageCache.cpp (right):

https://codereview.chromium.org/483493003/diff/1/src/core/SkScaledImageCache....
src/core/SkScaledImageCache.cpp:282: const SkIRect& bounds) {
This function doesn't need any more.

[reed1, 2014-08-21 16:32:46]

https://codereview.chromium.org/483493003/diff/1/src/core/SkScaledImageCache.cpp
File src/core/SkScaledImageCache.cpp (right):

https://codereview.chromium.org/483493003/diff/1/src/core/SkScaledImageCache....
src/core/SkScaledImageCache.cpp:282: const SkIRect& bounds) {
On 2014/08/21 16:15:03, qiankun wrote:
> This function doesn't need any more.

Good catch. Done.

[reed1, 2014-08-21 16:38:48]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-08-21 16:39:56]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/reed@google.com/483493003/40001

[commit-bot: I haz the power, 2014-08-21 16:47:02]

Committed patchset #3 (40001) as 04617139f7f715bdc05a32a58e65e3c208bccff4