Issue 483403005: GN build improvemenst

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 483403005: GN build improvemenst (Closed)

Created:
6 years, 4 months ago by brettw

Modified:
6 years, 3 months ago

Reviewers:
jamesr

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Committed: https://crrev.com/48c29f238165e02c0e6c56c406c4c0ad8fd0f1cc Cr-Commit-Position: refs/heads/master@{#291729}

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -38 lines)			Patch
M	build/util/BUILD.gn	View	1 2 3	1 chunk	+0 lines, -29 lines	0 comments	Download
M	tools/gn/BUILD.gn	View	1 2	2 chunks	+17 lines, -1 line	0 comments	Download
M	tools/gn/gn_main.cc	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
A	tools/gn/last_commit_position.py	View	1 2	1 chunk	+101 lines, -0 lines	0 comments	Download
M	ui/BUILD.gn	View		1 chunk	+8 lines, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

brettw

brettw@chromium.org changed reviewers: + jamesr@chromium.org

6 years, 4 months ago (2014-08-25 18:20:53 UTC) #1

brettw

Committed patchset #4 to pending queue manually as 52769c8 (presubmit successful).

6 years, 4 months ago (2014-08-25 19:07:12 UTC) #4

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:36:25 UTC) #5

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/48c29f238165e02c0e6c56c406c4c0ad8fd0f1cc
Cr-Commit-Position: refs/heads/master@{#291729}