Use NodeTraversal instead of ElementTraversal in VisitedLinkState

Use NodeTraversal instead of ElementTraversal in VisitedLinkState

Use NodeTraversal instead of ElementTraversal in VisitedLinkState to avoid
redundant Node::isElementNode() checks. Since isLink() is defined on Node, and
not on Element, we can simply iterate through all Nodes and then calls isLink()
on them (instead of isElementNode() && toElement(node).isLink()).

R=esprehn@chromium.org, adamk@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180677

[adamk, 2014-08-20 18:45:51]

lgtm

[Inactive, 2014-08-20 18:46:12]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-08-20 18:46:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/483383002/1

[commit-bot: I haz the power, 2014-08-20 18:50:50]

Committed patchset #1 (1) as 180677

[esprehn, 2014-08-20 21:44:52]

https://codereview.chromium.org/483383002/diff/1/Source/core/dom/VisitedLinkS...
File Source/core/dom/VisitedLinkState.cpp (right):

https://codereview.chromium.org/483383002/diff/1/Source/core/dom/VisitedLinkS...
Source/core/dom/VisitedLinkState.cpp:68:
node->setNeedsStyleRecalc(SubtreeStyleChange);
Note that this code is busted because it doesn't walk into ShadowRoots.

You need to refactor the loop into a function and then do

for (ShadowRoot* root = node->youngestShadowRoot(); root; root =
root->olderShadowRoot())
  invalidateStyleForAllLinks(root);

[adamk, 2014-08-20 21:48:46]

https://codereview.chromium.org/483383002/diff/1/Source/core/dom/VisitedLinkS...
File Source/core/dom/VisitedLinkState.cpp (right):

https://codereview.chromium.org/483383002/diff/1/Source/core/dom/VisitedLinkS...
Source/core/dom/VisitedLinkState.cpp:68:
node->setNeedsStyleRecalc(SubtreeStyleChange);
On 2014/08/20 21:44:52, esprehn wrote:
> Note that this code is busted because it doesn't walk into ShadowRoots.
> 
> You need to refactor the loop into a function and then do
> 
> for (ShadowRoot* root = node->youngestShadowRoot(); root; root =
> root->olderShadowRoot())
>   invalidateStyleForAllLinks(root);

This isn't newly-broken, right? The existing code already wasn't doing anything
special about ShadowRoots.

[esprehn, 2014-08-20 21:52:03]

Filed a bug for the Shadow DOM issue http://crbug.com/405707

https://codereview.chromium.org/483383002/diff/1/Source/core/dom/VisitedLinkS...
File Source/core/dom/VisitedLinkState.cpp (right):

https://codereview.chromium.org/483383002/diff/1/Source/core/dom/VisitedLinkS...
Source/core/dom/VisitedLinkState.cpp:68:
node->setNeedsStyleRecalc(SubtreeStyleChange);
On 2014/08/20 21:48:45, adamk wrote:
> On 2014/08/20 21:44:52, esprehn wrote:
> > Note that this code is busted because it doesn't walk into ShadowRoots.
> > 
> > You need to refactor the loop into a function and then do
> > 
> > for (ShadowRoot* root = node->youngestShadowRoot(); root; root =
> > root->olderShadowRoot())
> >   invalidateStyleForAllLinks(root);
> 
> This isn't newly-broken, right? The existing code already wasn't doing
anything
> special about ShadowRoots.

Correct, but there's an isElement() check inside the shadow root logic you need,
so this refactor doesn't really do much once we fix that.