Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 483343002: Rename TouchList::create() to TouchList::adopt() for clarity (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/dom/TouchList.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 5223 matching lines...) Expand 10 before | Expand all | Expand 10 after
5234 // FIXME: It's not clear from the documentation at 5234 // FIXME: It's not clear from the documentation at
5235 // http://developer.apple.com/library/safari/#documentation/UserExperience/R eference/DocumentAdditionsReference/DocumentAdditions/DocumentAdditions.html 5235 // http://developer.apple.com/library/safari/#documentation/UserExperience/R eference/DocumentAdditionsReference/DocumentAdditions/DocumentAdditions.html
5236 // when this method should throw and nor is it by inspection of iOS behavior . It would be nice to verify any cases where it throws under iOS 5236 // when this method should throw and nor is it by inspection of iOS behavior . It would be nice to verify any cases where it throws under iOS
5237 // and implement them here. See https://bugs.webkit.org/show_bug.cgi?id=4781 9 5237 // and implement them here. See https://bugs.webkit.org/show_bug.cgi?id=4781 9
5238 LocalFrame* frame = window ? window->frame() : this->frame(); 5238 LocalFrame* frame = window ? window->frame() : this->frame();
5239 return Touch::create(frame, target, identifier, FloatPoint(screenX, screenY) , FloatPoint(pageX, pageY), FloatSize(radiusX, radiusY), rotationAngle, force); 5239 return Touch::create(frame, target, identifier, FloatPoint(screenX, screenY) , FloatPoint(pageX, pageY), FloatSize(radiusX, radiusY), rotationAngle, force);
5240 } 5240 }
5241 5241
5242 PassRefPtrWillBeRawPtr<TouchList> Document::createTouchList(WillBeHeapVector<Ref PtrWillBeMember<Touch> >& touches) const 5242 PassRefPtrWillBeRawPtr<TouchList> Document::createTouchList(WillBeHeapVector<Ref PtrWillBeMember<Touch> >& touches) const
5243 { 5243 {
5244 return TouchList::create(touches); 5244 return TouchList::adopt(touches);
5245 } 5245 }
5246 5246
5247 DocumentLoader* Document::loader() const 5247 DocumentLoader* Document::loader() const
5248 { 5248 {
5249 if (!m_frame) 5249 if (!m_frame)
5250 return 0; 5250 return 0;
5251 5251
5252 DocumentLoader* loader = m_frame->loader().documentLoader(); 5252 DocumentLoader* loader = m_frame->loader().documentLoader();
5253 if (!loader) 5253 if (!loader)
5254 return 0; 5254 return 0;
(...skipping 540 matching lines...) Expand 10 before | Expand all | Expand 10 after
5795 using namespace blink; 5795 using namespace blink;
5796 void showLiveDocumentInstances() 5796 void showLiveDocumentInstances()
5797 { 5797 {
5798 WeakDocumentSet& set = liveDocumentSet(); 5798 WeakDocumentSet& set = liveDocumentSet();
5799 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 5799 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
5800 for (WeakDocumentSet::const_iterator it = set.begin(); it != set.end(); ++it ) { 5800 for (WeakDocumentSet::const_iterator it = set.begin(); it != set.end(); ++it ) {
5801 fprintf(stderr, "- Document %p URL: %s\n", *it, (*it)->url().string().ut f8().data()); 5801 fprintf(stderr, "- Document %p URL: %s\n", *it, (*it)->url().string().ut f8().data());
5802 } 5802 }
5803 } 5803 }
5804 #endif 5804 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/TouchList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698