Issue 483323002: Print max RSS in GM and nanobench too.

Issue 483323002: Print max RSS in GM and nanobench too. (Closed)

Created:
6 years, 4 months ago by mtklein_C

Modified:
6 years, 4 months ago

Reviewers:
hal.canary, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Print max RSS in GM and nanobench too. Everyone used MB, so update the API to just return that. BUG=skia: Committed: https://skia.googlesource.com/skia/+/afb4379dbca4d4d3824ace183a7348d24bc1589f

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -18 lines)			Patch
M	bench/nanobench.cpp	View	3 chunks	+4 lines, -2 lines	1 comment	Download
M	dm/DMReporter.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	gm/gmmain.cpp	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	gyp/bench.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/dm.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/gm.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/tools.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/ProcStats.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/ProcStats.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	tools/render_pdfs_main.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

hal.canary

https://codereview.chromium.org/483323002/diff/1/bench/nanobench.cpp File bench/nanobench.cpp (right): https://codereview.chromium.org/483323002/diff/1/bench/nanobench.cpp#newcode667 bench/nanobench.cpp:667: , sk_tools::getMaxResidentSetSizeMB() Is it okay to print -1 here?

6 years, 4 months ago (2014-08-19 21:35:59 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/483323002/1

6 years, 4 months ago (2014-08-19 21:41:46 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-19 22:56:03 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (1) as afb4379dbca4d4d3824ace183a7348d24bc1589f

Expand Messages | Collapse Messages