Issue 483263003: ARM64: Remove ToOperand32I and ToOperand32U.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 483263003: ARM64: Remove ToOperand32I and ToOperand32U. (Closed)

Created:
6 years, 4 months ago by jbramley

Modified:
6 years, 4 months ago

Reviewers:
ulan, jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

ARM64: Remove ToOperand32I and ToOperand32U. These were front-ends to ToOperand32, to specify sign-extension. However, since r22148, bits 63-32 are ignored for 32-bit operations anyway, so there's no need for the caller to be explicit. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23199

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -55 lines)			Patch
	M	src/arm64/lithium-codegen-arm64.h	View		2 chunks	+3 lines, -19 lines	0 comments	Download
	M	src/arm64/lithium-codegen-arm64.cc	View		11 chunks	+17 lines, -36 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jbramley

6 years, 4 months ago (2014-08-19 13:32:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 23199 (presubmit successful).

Expand Messages | Collapse Messages