Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 48323005: Add a basic NativeViewportX11 for Mojo (Closed)

Created:
7 years, 1 month ago by abarth-chromium
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Add a basic NativeViewportX11 for Mojo This CL adds a basic implementation of NativeViewport for X11. It puts a window on screen and initializes GL for that window. One disadvantage of this CL is that it requires use_aura to be set to 1 in GYP_DEFINES. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232960

Patch Set 1 #

Patch Set 2 : Make GL work #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -2 lines) Patch
M mojo/mojo.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_x11.cc View 1 2 chunks +61 lines, -2 lines 0 comments Download
M mojo/shell/desktop/mojo_main.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
abarth-chromium
7 years, 1 month ago (2013-11-04 22:49:30 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 1 month ago (2013-11-04 22:55:16 UTC) #2
abarth-chromium
I got GL working, so I rolled it into this CL too.
7 years, 1 month ago (2013-11-04 23:15:32 UTC) #3
Ben Goodger (Google)
slgtm
7 years, 1 month ago (2013-11-04 23:16:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/48323005/40001
7 years, 1 month ago (2013-11-04 23:30:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/48323005/40001
7 years, 1 month ago (2013-11-05 03:04:29 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-05 06:58:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/48323005/40001
7 years, 1 month ago (2013-11-05 07:08:26 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 13:45:03 UTC) #9
Message was sent while issue was closed.
Change committed as 232960

Powered by Google App Engine
This is Rietveld 408576698