sdk/lib/_internal/compiler/compiler.dart - Issue 48323003: Implement fromEnvironment on bool, int, String in dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/compiler.dart

Issue 48323003: Implement fromEnvironment on bool, int, String in dart2js. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/apiimpl.dart » ('j') | sdk/lib/_internal/compiler/implementation/compile_time_constants.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/compiler.dart

===================================================================

--- sdk/lib/_internal/compiler/compiler.dart (revision 29517)

+++ sdk/lib/_internal/compiler/compiler.dart (working copy)

@@ -85,8 +85,9 @@

Uri packageRoot,

CompilerInputProvider inputProvider,

DiagnosticHandler handler,

- [List<String> options = const [],

- CompilerOutputProvider outputProvider]) {

+ [List<String> options = const [],

+ CompilerOutputProvider outputProvider,

+ Map<String, dynamic> environment = const {}]) {

if (!libraryRoot.path.endsWith("/")) {

throw new ArgumentError("libraryRoot must end with a /");

}

@@ -100,7 +101,8 @@

handler,

libraryRoot,

packageRoot,

- options);

+ options,

+ environment);

// TODO(ahe): Use the value of the future (which signals success or failure).

return compiler.run(script).then((_) {

String code = compiler.assembledCode;