Implement fromEnvironment on bool, int, String in dart2js.

sdk/lib/_internal/compiler/implementation/compiler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js;
 
 /**
  * If true, print a warning for each method that was resolved, but not
  * compiled.
  */
@@ skipping 447 matching lines @@
   // Initialized when dart:mirrors is loaded.
   ClassElement deferredLibraryClass;
 
   ClassElement jsInvocationMirrorClass;
   /// Document class from dart:mirrors.
   ClassElement documentClass;
   Element assertMethod;
   Element identicalFunction;
   Element functionApplyMethod;
   Element invokeOnMethod;
+  Element intEnvironment;
+  Element boolEnvironment;
+  Element stringEnvironment;
+
+  fromEnvironment(String name) => null;
 
   Element get currentElement => _currentElement;
 
   String tryToString(object) {
     try {
       return object.toString();
     } catch (_) {
       return '<exception in toString()>';
     }
   }
@@ skipping 359 matching lines @@
     if (mirrorSystemClass == cls) {
       mirrorSystemGetNameFunction =
         cls.lookupLocalMember('getName');
     } else if (symbolClass == cls) {
       symbolConstructor = cls.constructors.head;
     } else if (symbolImplementationClass == cls) {
       symbolValidatedConstructor = symbolImplementationClass.lookupConstructor(
           symbolValidatedConstructorSelector);
     } else if (mirrorsUsedClass == cls) {
       mirrorsUsedConstructor = cls.constructors.head;
+    } else if (intClass == cls) {
+      intEnvironment = intClass.lookupConstructor(
+          new Selector.callConstructor('fromEnvironment', null, 2));
+    } else if (stringClass == cls) {
+      stringEnvironment = stringClass.lookupConstructor(
+          new Selector.callConstructor('fromEnvironment', null, 2));
+    } else if (boolClass == cls) {
+      boolEnvironment = boolClass.lookupConstructor(
+          new Selector.callConstructor('fromEnvironment', null, 1));

[kasperl, 2013/10/30 13:35:25]

Again, I don't really see why bool.fromEnvironment shouldn't allow a default
value.

[ngeoffray, 2013/10/30 15:13:59]

Done.

     }
   }
 
   Future<LibraryElement> scanBuiltinLibrary(String filename);
 
   void initializeSpecialClasses() {
     final List missingCoreClasses = [];
     ClassElement lookupCoreClass(String name) {
       ClassElement result = coreLibrary.find(name);
       if (result == null) {
@@ skipping 766 matching lines @@
 
   void close() {}
 
   toString() => name;
 
   /// Convenience method for getting an [api.CompilerOutputProvider].
   static NullSink outputProvider(String name, String extension) {
     return new NullSink('$name.$extension');
   }
 }