Add font family selector ui for distilled page viewer.

Add font family selector ui for distilled page viewer.

Builds on https://codereview.chromium.org/430473007 and adds the UI
for setting font family.
BUG=383630
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290968

[Yaron, 2014-08-19 02:35:54]

newt: general ui goodness
nyquist: owners

[Yaron, 2014-08-20 20:30:35]

I can has code review?

I updated it to not use the enum for storing the typeface. The generated enums
will be changed to be directly based on C++ code (http://crbug.com/405532) so
this won't work.

[newt (away), 2014-08-20 20:54:51]

You has code review.

nits, then lgtm

https://codereview.chromium.org/483183002/diff/80001/chrome/android/java/res/...
File chrome/android/java/res/values/arrays.xml (right):

https://codereview.chromium.org/483183002/diff/80001/chrome/android/java/res/...
chrome/android/java/res/values/arrays.xml:1: <?xml version="1.0"
encoding="utf-8"?>
copyright

https://codereview.chromium.org/483183002/diff/80001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsView.java
(right):

https://codereview.chromium.org/483183002/diff/80001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsView.java:62:
private Spinner mFontFamilyView;
s/View/Spinner

https://codereview.chromium.org/483183002/diff/80001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsView.java:117:
android.R.layout.simple_spinner_item,
getContext().getResources().getStringArray(
s/getContext().getResources()/getResources()

https://codereview.chromium.org/483183002/diff/80001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsView.java:131:
private View maybeOverrideTypeFace(View view, int position) {
What does the "maybe" refer to? Is view sometimes not a TextView?

https://codereview.chromium.org/483183002/diff/80001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsView.java:171:
ViewGroup.LayoutParams layoutParams =
does this fit on one line?

[Yaron, 2014-08-20 21:01:22]

thanks

https://codereview.chromium.org/483183002/diff/80001/chrome/android/java/res/...
File chrome/android/java/res/values/arrays.xml (right):

https://codereview.chromium.org/483183002/diff/80001/chrome/android/java/res/...
chrome/android/java/res/values/arrays.xml:1: <?xml version="1.0"
encoding="utf-8"?>
On 2014/08/20 20:54:51, newt wrote:
> copyright

Done.

https://codereview.chromium.org/483183002/diff/80001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsView.java
(right):

https://codereview.chromium.org/483183002/diff/80001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsView.java:62:
private Spinner mFontFamilyView;
On 2014/08/20 20:54:51, newt wrote:
> s/View/Spinner

Done.

https://codereview.chromium.org/483183002/diff/80001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsView.java:117:
android.R.layout.simple_spinner_item,
getContext().getResources().getStringArray(
On 2014/08/20 20:54:51, newt wrote:
> s/getContext().getResources()/getResources()

Done.

https://codereview.chromium.org/483183002/diff/80001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsView.java:131:
private View maybeOverrideTypeFace(View view, int position) {
On 2014/08/20 20:54:51, newt wrote:
> What does the "maybe" refer to? Is view sometimes not a TextView?

I assumed that OEM could make it non-TextView. However, I also later specified
my own view style so it should always be a TextView. Renamed but I kept the "if"
for paranoia's sake

https://codereview.chromium.org/483183002/diff/80001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsView.java:171:
ViewGroup.LayoutParams layoutParams =
On 2014/08/20 20:54:51, newt wrote:
> does this fit on one line?

This was eclipse auto-fixing but ya, I can make it one line.

[nyquist, 2014-08-20 23:32:39]

lgtm

https://codereview.chromium.org/483183002/diff/100001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsView.java
(right):

https://codereview.chromium.org/483183002/diff/100001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsView.java:161:
// nothing to do.
Immensely small nit: "Nothing"

[Yaron, 2014-08-20 23:36:18]

The CQ bit was checked by yfriedman@chromium.org

[commit-bot: I haz the power, 2014-08-20 23:37:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yfriedman@chromium.org/483183002/120001

[commit-bot: I haz the power, 2014-08-21 00:57:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[commit-bot: I haz the power, 2014-08-21 01:00:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-21 01:00:24]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Yaron, 2014-08-21 01:02:19]

The CQ bit was checked by yfriedman@chromium.org

[commit-bot: I haz the power, 2014-08-21 01:03:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yfriedman@chromium.org/483183002/120001

[commit-bot: I haz the power, 2014-08-21 01:05:38]

Committed patchset #6 (120001) as 290968