Introduce ES6 iterator for DOM objects.

Source/bindings/core/v8/V8DOMConfiguration.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 116 matching lines @@
         const char* const svalue;
         ConstantType type;
     };
 
     static void installConstants(v8::Handle<v8::FunctionTemplate>, v8::Handle<v8::ObjectTemplate>, const ConstantConfiguration*, size_t constantCount, v8::Isolate*);
 
     // MethodConfiguration translates into calls to Set() for setting up an
     // object's callbacks. It sets the method on both the FunctionTemplate or
     // the ObjectTemplate.
     struct MethodConfiguration {
+        v8::Local<v8::Name> getName(v8::Isolate* isolate) const { return v8AtomicString(isolate, name); }

[haraken, 2014/08/25 06:22:00]

getName => name

Blink doesn't use 'get'.

[yhirano, 2014/08/25 06:54:58]

renamed to methodName to avoid conflict.

+        v8::FunctionCallback getCallbackForWorld(const DOMWrapperWorld& world) const

[haraken, 2014/08/25 06:22:00]

getCallbackForWorld => callbackForWorld

[yhirano, 2014/08/25 06:54:58]

Done.

+        {
+            return world.isMainWorld() && callbackForMainWorld ? callbackForMainWorld : callback;
+        }
+
         const char* const name;
         v8::FunctionCallback callback;
         v8::FunctionCallback callbackForMainWorld;
         int length;
         ExposeConfiguration exposeConfiguration;
     };
 
+    struct SymbolKeyedMethodConfiguration {
+        v8::Local<v8::Name> getName(v8::Isolate* isolate) const { return getSymbol(isolate); }

[haraken, 2014/08/25 06:22:00]

getName => name

[yhirano, 2014/08/25 06:54:58]

Done.

+        v8::FunctionCallback getCallbackForWorld(const DOMWrapperWorld& world) const

[haraken, 2014/08/25 06:22:00]

getCallbackForWorld => callbackForWorld

[yhirano, 2014/08/25 06:54:58]

Done.

+        {
+            return world.isMainWorld() && callbackForMainWorld ? callbackForMainWorld : callback;
+        }
+
+        v8::Local<v8::Symbol> (*getSymbol)(v8::Isolate*);
+        v8::FunctionCallback callback;
+        v8::FunctionCallback callbackForMainWorld;

[haraken, 2014/08/25 06:22:00]

Now that you don't support per-world-bindings for Iterators, can you drop
callbackForMainWorld from SymbolKeyedMethodConfiguration?

[yhirano, 2014/08/25 06:54:58]

Done.

+        int length;
+        ExposeConfiguration exposeConfiguration;
+    };
+
     static void installMethods(v8::Handle<v8::ObjectTemplate>, v8::Handle<v8::Signature>, v8::PropertyAttribute, const MethodConfiguration*, size_t callbackCount, v8::Isolate*);
 
-    template <class Template>
-    static void installMethod(v8::Handle<Template> prototype, v8::Handle<v8::Signature> signature, v8::PropertyAttribute attribute, const MethodConfiguration& callback, v8::Isolate* isolate)
+    template <class ObjectOrTemplate, class Configuration>
+    static void installMethod(v8::Handle<ObjectOrTemplate> objectOrTemplate, v8::Handle<v8::Signature> signature, v8::PropertyAttribute attribute, const Configuration& callback, v8::Isolate* isolate)
     {
         DOMWrapperWorld& world = DOMWrapperWorld::current(isolate);
         if (callback.exposeConfiguration == OnlyExposedToPrivateScript && !world.isPrivateScriptIsolatedWorld())
             return;
 
-        v8::Local<v8::FunctionTemplate> functionTemplate = functionTemplateForMethod(signature, callback, isolate);
-        prototype->Set(v8AtomicString(isolate, callback.name), functionTemplate, attribute);
-    }
-
-    static void installMethod(v8::Handle<v8::Object> object, v8::Handle<v8::Signature> signature, v8::PropertyAttribute, const MethodConfiguration& callback, v8::Isolate* isolate)
-    {
-        DOMWrapperWorld& world = DOMWrapperWorld::current(isolate);
-        if (callback.exposeConfiguration == OnlyExposedToPrivateScript && !world.isPrivateScriptIsolatedWorld())
-            return;
-
-        v8::Local<v8::FunctionTemplate> functionTemplate = functionTemplateForMethod(signature, callback, isolate);
-        object->Set(v8AtomicString(isolate, callback.name), functionTemplate->GetFunction());
+        v8::Local<v8::FunctionTemplate> functionTemplate = functionTemplateForCallback(signature, callback.getCallbackForWorld(world), callback.length, isolate);
+        setMethod(objectOrTemplate, callback.getName(isolate), functionTemplate, attribute);
     }
 
     static void installAccessors(v8::Handle<v8::ObjectTemplate>, v8::Handle<v8::Signature>, const AccessorConfiguration*, size_t accessorCount, v8::Isolate*);
 
     static v8::Local<v8::Signature> installDOMClassTemplate(v8::Handle<v8::FunctionTemplate>, const char* interfaceName, v8::Handle<v8::FunctionTemplate> parentClass, size_t fieldCount,
         const AttributeConfiguration*, size_t attributeCount,
         const AccessorConfiguration*, size_t accessorCount,
         const MethodConfiguration*, size_t callbackCount,
         v8::Isolate*);
 
     static v8::Handle<v8::FunctionTemplate> domClassTemplate(v8::Isolate*, WrapperTypeInfo*, void (*)(v8::Handle<v8::FunctionTemplate>, v8::Isolate*));
 
 private:
-    static v8::Handle<v8::FunctionTemplate> functionTemplateForMethod(v8::Handle<v8::Signature>, const MethodConfiguration&, v8::Isolate*);
+    static void setMethod(v8::Handle<v8::Object> target, v8::Handle<v8::Name> name, v8::Handle<v8::FunctionTemplate> functionTemplate, v8::PropertyAttribute attribute)
+    {
+        target->Set(name, functionTemplate->GetFunction());
+    }
+    static void setMethod(v8::Handle<v8::FunctionTemplate> target, v8::Handle<v8::Name> name, v8::Handle<v8::FunctionTemplate> functionTemplate, v8::PropertyAttribute attribute)
+    {
+        target->Set(name, functionTemplate, attribute);
+    }
+    static void setMethod(v8::Handle<v8::ObjectTemplate> target, v8::Handle<v8::Name> name, v8::Handle<v8::FunctionTemplate> functionTemplate, v8::PropertyAttribute attribute)
+    {
+        target->Set(name, functionTemplate, attribute);
+    }
+
+    static v8::Handle<v8::FunctionTemplate> functionTemplateForCallback(v8::Handle<v8::Signature>, v8::FunctionCallback, int length, v8::Isolate*);
 };
 
 } // namespace blink
 
 #endif // V8DOMConfiguration_h