Make table text the same size as body text. Add styles to support table reformatting.

Make table text the same size as body text. Add styles to support table reformatting.

BUG=none
R= mkearney@chromium.org, smain@chromium.org, binji@chromium.org, binji@google.com, kalman@chromium.org
TEST=none
NOTRY=true
(documentation only change)

Committed: https://crrev.com/6b1e161b900e9e7f714b55eb96b907f173cf0296
Cr-Commit-Position: refs/heads/master@{#292305}

[smain, 2014-08-19 15:03:05]

Is there a better way to show the actual diffs you made in the CSS? This
suggests that the entire file was changed because it's just one line.

[mkearney1, 2014-08-19 15:28:21]

On 2014/08/19 15:03:05, smain wrote:
> Is there a better way to show the actual diffs you made in the CSS? This
> suggests that the entire file was changed because it's just one line.

Joe,

You will need to update the appropriate sass file (might be in here:
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs...).

Then you need to run a script to re-generate the out folder. Inside the cl, you
put both the updated sass changes and the updated site.css. We can jump on a
call today and I can show you.

[chromium-reviews, 2014-08-19 16:05:25]

The CSS has had all the white space squeezed out of it making it a single
very long line. I inherited it that way. I'm guessing this is about
shrinking payloads.

Joe Medley | Technical Writer | jmedley@google.com | 816-678-7195


On Tue, Aug 19, 2014 at 9:03 AM, <smain@chromium.org> wrote:

> Is there a better way to show the actual diffs you made in the CSS? This
> suggests that the entire file was changed because it's just one line.
>
>
> https://codereview.chromium.org/483163002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2014-08-19 16:08:19]

I want to make sure I'm getting this. Site.css is composited. I need to
change its source.

Joe Medley | Technical Writer | jmedley@google.com | 816-678-7195


On Tue, Aug 19, 2014 at 9:28 AM, <mkearney@chromium.org> wrote:

> On 2014/08/19 15:03:05, smain wrote:
>
>> Is there a better way to show the actual diffs you made in the CSS? This
>> suggests that the entire file was changed because it's just one line.
>>
>
> Joe,
>
> You will need to update the appropriate sass file (might be in here:
> http://src.chromium.org/viewvc/chrome/trunk/src/
> chrome/common/extensions/docs/static/sass/site.scss?sortby=date).
>
> Then you need to run a script to re-generate the out folder. Inside the
> cl, you
> put both the updated sass changes and the updated site.css. We can jump on
> a
> call today and I can show you.
>
> https://codereview.chromium.org/483163002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2014-08-19 17:51:44]

Yep. site.css brings together several .scss files. So you need to figure
out which one controls the styles you are changing.


On Tue, Aug 19, 2014 at 9:07 AM, Joe Medley <jmedley@google.com> wrote:

> I want to make sure I'm getting this. Site.css is composited. I need to
> change its source.
>
> Joe Medley | Technical Writer | jmedley@google.com | 816-678-7195
>
>
> On Tue, Aug 19, 2014 at 9:28 AM, <mkearney@chromium.org> wrote:
>
>> On 2014/08/19 15:03:05, smain wrote:
>>
>>> Is there a better way to show the actual diffs you made in the CSS? This
>>> suggests that the entire file was changed because it's just one line.
>>>
>>
>> Joe,
>>
>> You will need to update the appropriate sass file (might be in here:
>> http://src.chromium.org/viewvc/chrome/trunk/src/
>> chrome/common/extensions/docs/static/sass/site.scss?sortby=date).
>>
>> Then you need to run a script to re-generate the out folder. Inside the
>> cl, you
>> put both the updated sass changes and the updated site.css. We can jump
>> on a
>> call today and I can show you.
>>
>> https://codereview.chromium.org/483163002/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2014-08-19 18:16:36]

Do you know which script makes site.css?

Joe Medley | Technical Writer | jmedley@google.com | 816-678-7195


On Tue, Aug 19, 2014 at 11:51 AM, Meggin Kearney <mkearney@google.com>
wrote:

> Yep. site.css brings together several .scss files. So you need to figure
> out which one controls the styles you are changing.
>
>
> On Tue, Aug 19, 2014 at 9:07 AM, Joe Medley <jmedley@google.com> wrote:
>
>> I want to make sure I'm getting this. Site.css is composited. I need to
>> change its source.
>>
>> Joe Medley | Technical Writer | jmedley@google.com | 816-678-7195
>>
>>
>> On Tue, Aug 19, 2014 at 9:28 AM, <mkearney@chromium.org> wrote:
>>
>>> On 2014/08/19 15:03:05, smain wrote:
>>>
>>>> Is there a better way to show the actual diffs you made in the CSS? This
>>>> suggests that the entire file was changed because it's just one line.
>>>>
>>>
>>> Joe,
>>>
>>> You will need to update the appropriate sass file (might be in here:
>>> http://src.chromium.org/viewvc/chrome/trunk/src/
>>> chrome/common/extensions/docs/static/sass/site.scss?sortby=date).
>>>
>>> Then you need to run a script to re-generate the out folder. Inside the
>>> cl, you
>>> put both the updated sass changes and the updated site.css. We can jump
>>> on a
>>> call today and I can show you.
>>>
>>> https://codereview.chromium.org/483163002/
>>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2014-08-19 18:17:43]

Yep. You will need a copy of it. It's not in the folder!

I will send you the script with instructions.

Meggin


On Tue, Aug 19, 2014 at 11:16 AM, Joe Medley <jmedley@google.com> wrote:

> Do you know which script makes site.css?
>
> Joe Medley | Technical Writer | jmedley@google.com | 816-678-7195
>
>
> On Tue, Aug 19, 2014 at 11:51 AM, Meggin Kearney <mkearney@google.com>
> wrote:
>
>> Yep. site.css brings together several .scss files. So you need to figure
>> out which one controls the styles you are changing.
>>
>>
>> On Tue, Aug 19, 2014 at 9:07 AM, Joe Medley <jmedley@google.com> wrote:
>>
>>> I want to make sure I'm getting this. Site.css is composited. I need to
>>> change its source.
>>>
>>> Joe Medley | Technical Writer | jmedley@google.com | 816-678-7195
>>>
>>>
>>> On Tue, Aug 19, 2014 at 9:28 AM, <mkearney@chromium.org> wrote:
>>>
>>>> On 2014/08/19 15:03:05, smain wrote:
>>>>
>>>>> Is there a better way to show the actual diffs you made in the CSS?
>>>>> This
>>>>> suggests that the entire file was changed because it's just one line.
>>>>>
>>>>
>>>> Joe,
>>>>
>>>> You will need to update the appropriate sass file (might be in here:
>>>> http://src.chromium.org/viewvc/chrome/trunk/src/
>>>> chrome/common/extensions/docs/static/sass/site.scss?sortby=date).
>>>>
>>>> Then you need to run a script to re-generate the out folder. Inside the
>>>> cl, you
>>>> put both the updated sass changes and the updated site.css. We can jump
>>>> on a
>>>> call today and I can show you.
>>>>
>>>> https://codereview.chromium.org/483163002/
>>>>
>>>
>>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jpmedley, 2014-08-26 19:54:55]

PTAL

Here's a picture of what the changes would do:
https://plus.google.com/photos/108653480353422372181/albums/60496477046764779...

[binji, 2014-08-26 20:28:54]

On 2014/08/26 19:54:55, jmedley wrote:
> PTAL
> 
> Here's a picture of what the changes would do:
>
https://plus.google.com/photos/108653480353422372181/albums/60496477046764779...

I don't have permission to view that picture...

[chromium-reviews, 2014-08-26 20:39:34]

Try again.

Joe Medley | Technical Writer | jmedley@google.com | 816-678-7195


On Tue, Aug 26, 2014 at 2:28 PM, <binji@chromium.org> wrote:

> On 2014/08/26 19:54:55, jmedley wrote:
>
>> PTAL
>>
>
>  Here's a picture of what the changes would do:
>>
>
> https://plus.google.com/photos/108653480353422372181/
> albums/6049647704676477985/6051963247476942674?pid=
> 6051963247476942674&oid=108653480353422372181
>
> I don't have permission to view that picture...
>
> https://codereview.chromium.org/483163002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[binji, 2014-08-26 22:05:06]

binji@chromium.org changed reviewers:
+ binji@chromium.org

[binji, 2014-08-26 22:05:07]

https://codereview.chromium.org/483163002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/static/sass/_typography.scss (right):

https://codereview.chromium.org/483163002/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/static/sass/_typography.scss:118: font-size: 14px;
should this use $body-font-size?

[jpmedley, 2014-08-26 23:11:05]

Yes. PTAL

[jpmedley, 2014-08-26 23:12:18]

https://codereview.chromium.org/483163002/diff/40001/chrome/common/extensions...
File chrome/common/extensions/docs/static/sass/_typography.scss (right):

https://codereview.chromium.org/483163002/diff/40001/chrome/common/extensions...
chrome/common/extensions/docs/static/sass/_typography.scss:18: font-size:
$body-font-size;
Didn't mean to swap this. It's a fat finger mistake.

[binji, 2014-08-26 23:26:57]

https://codereview.chromium.org/483163002/diff/40001/chrome/common/extensions...
File chrome/common/extensions/docs/static/css/out/site.css (right):

https://codereview.chromium.org/483163002/diff/40001/chrome/common/extensions...
chrome/common/extensions/docs/static/css/out/site.css:1: /*! Copyright 2014 The
Chromium Authors. All rights reserved.
your copy is not minified.

[jpmedley, 2014-08-27 15:12:26]

Sorry about that. PTAL

[binji, 2014-08-27 15:27:21]

lgtm (though you'll still need OWNERS approval)

[chromium-reviews, 2014-08-27 15:35:32]

Who's the owner?

Joe Medley | Technical Writer | jmedley@google.com | 816-678-7195


On Wed, Aug 27, 2014 at 8:27 AM, <binji@chromium.org> wrote:

> lgtm (though you'll still need OWNERS approval)
>
> https://codereview.chromium.org/483163002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2014-08-27 15:37:25]

+kalman@chromium.org


On Wed, Aug 27, 2014 at 8:35 AM, Joe Medley <jmedley@google.com> wrote:

> Who's the owner?
>
> Joe Medley | Technical Writer | jmedley@google.com | 816-678-7195
>
>
> On Wed, Aug 27, 2014 at 8:27 AM, <binji@chromium.org> wrote:
>
>> lgtm (though you'll still need OWNERS approval)
>>
>> https://codereview.chromium.org/483163002/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[not at google - send to devlin, 2014-08-27 19:30:24]

kalman@chromium.org changed reviewers:
+ kalman@chromium.org

[not at google - send to devlin, 2014-08-27 19:30:24]

lgtm but please either add a BUG or remove the blank BUG= field (preferably the
former, if one exists).

https://codereview.chromium.org/483163002/diff/60001/chrome/common/extensions...
File chrome/common/extensions/docs/static/sass/_typography.scss (left):

https://codereview.chromium.org/483163002/diff/60001/chrome/common/extensions...
chrome/common/extensions/docs/static/sass/_typography.scss:18: color: $text;
This change doesn't look necessary

[chromium-reviews, 2014-08-27 21:15:34]

Thanks for the heads up on BUG=. I'm new here.

The other item is a fat finger mistake I didn't notice until it was upload.
Since it didn't break anything, so I left it.

Joe Medley | Technical Writer | jmedley@google.com | 816-678-7195


On Wed, Aug 27, 2014 at 12:30 PM, <kalman@chromium.org> wrote:

> lgtm but please either add a BUG or remove the blank BUG= field
> (preferably the
> former, if one exists).
>
>
> https://codereview.chromium.org/483163002/diff/60001/
> chrome/common/extensions/docs/static/sass/_typography.scss
> File chrome/common/extensions/docs/static/sass/_typography.scss (left):
>
> https://codereview.chromium.org/483163002/diff/60001/
> chrome/common/extensions/docs/static/sass/_typography.scss#oldcode18
> chrome/common/extensions/docs/static/sass/_typography.scss:18: color:
> $text;
> This change doesn't look necessary
>
> https://codereview.chromium.org/483163002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[not at google - send to devlin, 2014-08-27 21:17:46]

On 2014/08/27 21:15:34, chromium-reviews wrote:
> Thanks for the heads up on BUG=. I'm new here.
> 
> The other item is a fat finger mistake I didn't notice until it was upload.
> Since it didn't break anything, so I left it.
> 

Please don't commit unnecessary changes.

[jpmedley, 2014-08-28 01:11:23]

Fixed. I'm committing.

[jpmedley, 2014-08-28 01:11:37]

The CQ bit was checked by jmedley@chromium.org

[commit-bot: I haz the power, 2014-08-28 01:12:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jmedley@chromium.org/483163002/80001

[commit-bot: I haz the power, 2014-08-28 01:14:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 01:14:06]

Failed to commit the patch.

[jpmedley, 2014-08-28 03:29:49]

The CQ bit was checked by jmedley@chromium.org

[commit-bot: I haz the power, 2014-08-28 03:31:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jmedley@chromium.org/483163002/80001

[commit-bot: I haz the power, 2014-08-28 03:32:53]

Committed patchset #5 (id:80001) as a81e2e0717faed718e15919ed94fd16973de7d2c

[commit-bot: I haz the power, 2014-09-10 02:56:57]

Patchset 5 (id:??) landed as
https://crrev.com/6b1e161b900e9e7f714b55eb96b907f173cf0296
Cr-Commit-Position: refs/heads/master@{#292305}

[pearlchen, 2014-09-12 19:53:40]

@jmedley	You may want to revisit this patch. I ended up finding this patch
because I had to hunt down quite a few discrepancies between: the CSS that's
live, the CSS that's committed to origin/master, and the CSS that gets generated
from the committed SASS files. 

In the next CSS update, you might notice some of your changes disappear because
they are not in the SCSS files. If you really want these changes in, please
create a new CL with these in the SCSS files and re-generate a new CSS file.

Here's a list of the main differences I found but you can run your own diff to
find the exact line numbers:

(1)
html {
  font-size: 100%
  line-height: 1.5em
}

versus

html {
  font-size: 16px;
  line-height: 1.5em
}

**** note: html font sizing is coming from _normalize.scss so I'm not sure you
meant to change it??  ****

(2)
pre strike {
  text-decoration: none;
  background-image: linear-gradient(rgba(0, 0, 0, 0) 7px, #cc1f1f 7px, #cc1f1f
9px, rgba(0, 0, 0, 0) 9px)
}

versus 
pre strike {
  text-decoration: none;
  background-image: linear-gradient(transparent 7px, #cc1f1f 7px, #cc1f1f 9px,
transparent 9px)
}

**** note: I would keep transparent here, no need to switch to rgba ****

(3) In a few spots:

background-image: linear-gradient(top ...
background-image: linear-gradient(bottom ...

versus

background-image: linear-gradient(to bottom, #008dfd 0%, #0370ea 100%);
background-image: linear-gradient(to top, #dcdcdc 46%, #fafafa 87%);

**** note: This is a correct update (currently blue buttons on DCC don't
properly show the gradient) but your change is no where to be found in the SCSS
file ****