Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 483133002: ninja win: don't expect pdb to be generated when GenerateDebugInformation: false (Closed)

Created:
6 years, 4 months ago by scottmg
Modified:
6 years, 4 months ago
Reviewers:
Nico, sky
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja win: don't expect pdb to be generated when GenerateDebugInformation: false if comparison was incorrect for truthy values when added at https://codereview.chromium.org/126443004/ (such as 'false'). Test addition fails before this CL. R=thakis@chromium.org, sky@chromium.org BUG=chromium:404872 Committed: https://code.google.com/p/gyp/source/detail?r=1967

Patch Set 1 #

Total comments: 2

Patch Set 2 : try enabling on msvs #

Patch Set 3 : separate out non-ninja-specific part #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M pylib/gyp/msvs_emulation.py View 1 chunk +1 line, -1 line 0 comments Download
A test/win/gyptest-link-pdb-no-output.py View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M test/win/gyptest-link-pdb-output.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M test/win/linker-flags/pdb-output.gyp View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
thakis@ as previous CL reviewer if you're not (very away) for gyp else, sky@ as ...
6 years, 4 months ago (2014-08-18 23:58:17 UTC) #1
Nico
lgtm, but with opportunity for bonus points: https://codereview.chromium.org/483133002/diff/1/test/win/linker-flags/pdb-output.gyp File test/win/linker-flags/pdb-output.gyp (right): https://codereview.chromium.org/483133002/diff/1/test/win/linker-flags/pdb-output.gyp#newcode44 test/win/linker-flags/pdb-output.gyp:44: 'GenerateDebugInformation': 'false', ...
6 years, 4 months ago (2014-08-19 00:04:11 UTC) #2
scottmg
https://codereview.chromium.org/483133002/diff/1/test/win/linker-flags/pdb-output.gyp File test/win/linker-flags/pdb-output.gyp (right): https://codereview.chromium.org/483133002/diff/1/test/win/linker-flags/pdb-output.gyp#newcode44 test/win/linker-flags/pdb-output.gyp:44: 'GenerateDebugInformation': 'false', On 2014/08/19 00:04:11, Nico (very away) wrote: ...
6 years, 4 months ago (2014-08-19 00:17:40 UTC) #3
Nico
lgtm with bonus points!
6 years, 4 months ago (2014-08-19 00:18:41 UTC) #4
scottmg
6 years, 4 months ago (2014-08-19 00:32:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as 1967 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698