Incoming references service request and UI.

runtime/vm/service.cc

Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 69e81cd35e8e9bad7e900cd9c6c592b25318cfb8..8b360103795d484c026522cd2a8db657618774a7 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -976,6 +976,55 @@ static bool ContainsNonInstance(const Object& obj) {
 }
 
 
+static bool HandleInboundReferences(Isolate* isolate,
+                                    Object* target,
+                                    intptr_t limit,
+                                    JSONStream* js) {
+  ObjectGraph graph(isolate);
+  Array& path = Array::Handle(Array::New(limit * 2));
+  intptr_t length = graph.InboundReferences(target, path);
+  JSONObject jsobj(js);
+  jsobj.AddProperty("type", "InboundReferences");
+  jsobj.AddProperty("id", "inbound_references");
+  {
+    JSONArray elements(&jsobj, "references");
+    Object& source = Object::Handle();
+    Smi& slot_offset = Smi::Handle();
+    Class& source_class = Class::Handle();
+    Field& field = Field::Handle();
+    Array& parent_field_map = Array::Handle();
+    limit = Utils::Minimum(limit, length);
+    for (intptr_t i = 0; i < limit; ++i) {
+      JSONObject jselement(&elements);
+      source = path.At(i * 2);
+      slot_offset ^= path.At((i * 2) + 1);
+
+      jselement.AddProperty("source", source);
+      jselement.AddProperty("slot", "<unknown>");
+      if (source.IsArray()) {
+        intptr_t element_index = slot_offset.Value() -
+            (Array::element_offset(0) >> kWordSizeLog2);
+        jselement.AddProperty("slot", element_index);
+      } else if (source.IsInstance()) {
+        source_class ^= source.clazz();
+        parent_field_map = source_class.OffsetToFieldMap();
+        intptr_t offset = slot_offset.Value();
+        if (offset > 0 && offset < parent_field_map.Length()) {
+          field ^= parent_field_map.At(offset);
+          jselement.AddProperty("slot", field);
+        }
+      }
+
+      // We nil out the array after generating the response to prevent
+      // reporting suprious references when repeatedly looking for the
+      // references to an object.
+      path.SetAt(i * 2, Object::null_object());
+    }
+  }
+  return true;
+}
+
+
 static bool HandleRetainingPath(Isolate* isolate,
                                 Object* obj,
                                 intptr_t limit,
@@ -1083,6 +1132,14 @@ static bool HandleInstanceCommands(Isolate* isolate,
       return true;
     }
     return HandleRetainingPath(isolate, obj, limit, js);
+  } else if (strcmp(action, "inbound_references") == 0) {
+    intptr_t limit;
+    if (!GetIntegerId(js->LookupOption("limit"), &limit)) {
+      PrintError(js, "inbound_references expects a 'limit' option\n",
+                 js->num_arguments());
+      return true;

[Cutch, 2014/08/21 20:08:56]

Did you not need to add 'inbound_references' to other things like code?

[rmacnak, 2014/08/21 22:06:45]

Currently it will just fail if you try to chase past non-instances and the UI
will give an empty result. I'd rather not sprinkle this all over the handlers in
this CL.

+    }
+    return HandleInboundReferences(isolate, obj, limit, js);
   }
 
   PrintError(js, "unrecognized action '%s'\n", action);