Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 48303004: Remove assertion in SetResourceConstraints. (Closed)

Created:
7 years, 1 month ago by titzer
Modified:
7 years, 1 month ago
Reviewers:
Sven Panne, rmcilroy
CC:
v8-dev
Visibility:
Public.

Description

Remove assertion in SetResourceConstraints. BUG=312233 R=rmcilroy@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17416

Patch Set 1 #

Patch Set 2 : Comment it out. #

Patch Set 3 : Comment out the ASSERT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/api.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
titzer
This ASSERT fails when debugging a chromium build with content_shell.
7 years, 1 month ago (2013-10-28 08:47:55 UTC) #1
Sven Panne
DBC: Please open a bug and assign it to you, so we don't forget to ...
7 years, 1 month ago (2013-10-28 08:57:27 UTC) #2
rmcilroy
On 2013/10/28 08:47:55, titzer wrote: > This ASSERT fails when debugging a chromium build with ...
7 years, 1 month ago (2013-10-28 09:30:11 UTC) #3
rmcilroy
On 2013/10/28 09:30:11, rmcilroy wrote: > On 2013/10/28 08:47:55, titzer wrote: > > This ASSERT ...
7 years, 1 month ago (2013-10-28 15:53:33 UTC) #4
titzer
On 2013/10/28 15:53:33, rmcilroy wrote: > On 2013/10/28 09:30:11, rmcilroy wrote: > > On 2013/10/28 ...
7 years, 1 month ago (2013-10-28 16:07:21 UTC) #5
rmcilroy
lgtm Thanks Ben!
7 years, 1 month ago (2013-10-28 16:14:39 UTC) #6
titzer
7 years, 1 month ago (2013-10-28 16:17:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r17416.

Powered by Google App Engine
This is Rietveld 408576698