Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 48303003: Handle the onerror content attribute for <body> and <frameset> (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Handle the onerror content attribute for <body> and <frameset> Firefox also passes the test. Presto fails on "Convert to function" everywhere, and IE11 was not tested. BUG=310630 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M LayoutTests/fast/dom/body-frameset-event-handlers.html View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/body-frameset-event-handlers-expected.txt View 1 chunk +12 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/script-tests/event-handlers.js View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/html/HTMLBodyElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLFrameSetElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
7 years, 1 month ago (2013-10-28 08:31:23 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-10-28 08:34:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/48303003/1
7 years, 1 month ago (2013-10-28 08:37:22 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-28 09:36:47 UTC) #4
Message was sent while issue was closed.
Change committed as 160708

Powered by Google App Engine
This is Rietveld 408576698