Issue 48303002: faster stack frame generation for accessor property ics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48303002: faster stack frame generation for accessor property ics (Closed)

Created:
7 years, 1 month ago by dcarney

Modified:
7 years, 1 month ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

faster stack frame generation for accessor property ics this is implemented for intel platforms only, as they are the only ones which show speed up with this change R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17903

Created: 7 years, 1 month ago

		Unified diffs	Side-by-side diffs	Stats (+249 lines, -104 lines)
	M	src/ia32/stub-cache-ia32.cc	View	8 chunks	+119 lines, -51 lines	0 comments
	M	src/x64/stub-cache-x64.cc	View	8 chunks	+130 lines, -53 lines	0 comments

Total messages: 3 (0 generated)

Sven Panne

LGTM, but please add tiny comments why one version is more compact/faster than the other ...

7 years, 1 month ago (2013-11-19 12:30:59 UTC) #2

dcarney

7 years, 1 month ago (2013-11-20 10:12:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r17903 (presubmit successful).