Move logic to clear ExtensionAction values to ExtensionActionAPI

chrome/browser/extensions/page_action_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/page_action_controller.h"
 
 #include <set>
 
 #include "base/lazy_instance.h"
 #include "base/metrics/histogram.h"
@@ skipping 46 matching lines @@
       web_contents_->GetBrowserContext(),
       *page_action,
       tab_id,
       web_contents_->GetLastCommittedURL().spec(),
       1 /* Button indication. We only ever pass left-click. */);
 
   return ExtensionAction::ACTION_NONE;
 }
 
 void PageActionController::OnNavigated() {
-  const ExtensionSet& extensions =
-      ExtensionRegistry::Get(web_contents_->GetBrowserContext())
-          ->enabled_extensions();
-  int tab_id = SessionTabHelper::IdForTab(web_contents_);
-  size_t num_current_actions = 0u;
-  for (ExtensionSet::const_iterator iter = extensions.begin();
-       iter != extensions.end();
-       ++iter) {
-    ExtensionAction* action = GetActionForExtension(*iter);
-    if (action) {
-      action->ClearAllValuesForTab(tab_id);
-      ++num_current_actions;
-    }
-  }
-
-  Profile* profile = GetProfile();
-  // Report the number of page actions for this profile, if we haven't already.
-  // TODO(rdevlin.cronin): This is wrong. Instead, it should record the number
-  // of page actions displayed per page.
-  if (!g_reported_for_profiles.Get().count(profile)) {
-    UMA_HISTOGRAM_COUNTS_100("PageActionController.ExtensionsWithPageActions",
-                             num_current_actions);
-    g_reported_for_profiles.Get().insert(profile);
-  }
-
-  LocationBarController::NotifyChange(web_contents_);
+  // Clearing extension action values is handled in TabHelper, so nothing to
+  // do here.
 }
 
 void PageActionController::OnExtensionActionUpdated(
     ExtensionAction* extension_action,
     content::WebContents* web_contents,
     content::BrowserContext* browser_context) {
   if (web_contents == web_contents_ &&
       extension_action->action_type() == ActionInfo::TYPE_PAGE)
     LocationBarController::NotifyChange(web_contents_);
 }
 
 Profile* PageActionController::GetProfile() {
   return Profile::FromBrowserContext(web_contents_->GetBrowserContext());
 }
 
 }  // namespace extensions