Claim some histograms.

Claim some histograms for appcache, domstorage, and sessionstorage.

[michaeln, 2014-08-19 00:48:25]

ptal

[Ilya Sherman, 2014-08-19 01:03:14]

LGTM % a nit:

https://codereview.chromium.org/482893004/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/482893004/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:48913: +  <int value="2" label="Failed
to open the database and failed to recover."/>
nit: I recommend using briefer labels, since these are going to be rendered as
the left column of a table.  You can use the format

<int value="N" label="Short">Longer description that's shown as a tooltip</int>

if you would like to include longer descriptions as well as brief ones.

[michaeln, 2014-08-19 19:46:33]

Could you take another look. After looking at the internal xml file, i found
some more to claim, including a handful of  DiskCache.3 stats for appcache.

@rvargas, is it ok to put your name on those too, is it ok to hoist those into
the public xml file? I didn't hoist the DiskCache.3 entries  that i do not see
in my browsers about:histograms display. Does that sound reasonable?

https://codereview.chromium.org/482893004/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/482893004/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:48913: +  <int value="2" label="Failed
to open the database and failed to recover."/>
On 2014/08/19 01:03:14, Ilya Sherman wrote:
> nit: I recommend using briefer labels, since these are going to be rendered as
> the left column of a table.  You can use the format
> 
> <int value="N" label="Short">Longer description that's shown as a
tooltip</int>
> 
> if you would like to include longer descriptions as well as brief ones.

Done.

[rvargas (doing something else), 2014-08-19 20:01:07]

I don't know what the policy is for old histograms... I thought we were just
adding the owner line to the internal file (that's what I did). There's also
some duplication in that moving only one type to the external file leaves some
support stuff on both files :(

As for adding me, I only added my name to histograms that I usually look at, so
I left "other type of caches" to be claimed by their users, if they consider
them important (in other words, you for AppCache). At this point I would
actually prefer to remove histograms for other backends, and I'm certainly not
adding them for new types (they are a lot, and take a lot of space).

[michaeln, 2014-08-19 22:16:57]

I'm assuming entries without owners will be deleted from these files at some
point. 

> I don't know what the policy is for old histograms... I thought we were just
> adding the owner line to the internal file (that's what I did). There's also
> some duplication in that moving only one type to the external file leaves some
> support stuff on both files :(

I don't like the duplication either. Is there a reason they're in the internal
file instead of he public file?


> As for adding me, I only added my name to histograms that I usually look at,
so
> I left "other type of caches" to be claimed by their users, if they consider
> them important (in other words, you for AppCache). At this point I would
> actually prefer to remove histograms for other backends, and I'm certainly not
> adding them for new types (they are a lot, and take a lot of space).

I'll take a closer look and remove more of them. Ok, I think there are only thr
that I'd like to keep.

DiskCache.3.Size
DiskCache.3.Error
DiskCache.3.DeleteFailed

[rvargas (doing something else), 2014-08-19 22:34:07]

On 2014/08/19 22:16:57, michaeln wrote:
> I'm assuming entries without owners will be deleted from these files at some
> point. 
> 
> > I don't know what the policy is for old histograms... I thought we were just
> > adding the owner line to the internal file (that's what I did). There's also
> > some duplication in that moving only one type to the external file leaves
some
> > support stuff on both files :(
> 
> I don't like the duplication either. Is there a reason they're in the internal
> file instead of he public file?

A long time ago, the policy was that we were not moving the histograms in bulk
from the old file to the new file. I don't know what's the current policy.

> 
> 
> > As for adding me, I only added my name to histograms that I usually look at,
> so
> > I left "other type of caches" to be claimed by their users, if they consider
> > them important (in other words, you for AppCache). At this point I would
> > actually prefer to remove histograms for other backends, and I'm certainly
not
> > adding them for new types (they are a lot, and take a lot of space).
> 
> I'll take a closer look and remove more of them. Ok, I think there are only
thr
> that I'd like to keep.
> 
> DiskCache.3.Size

oops. That should be Size2 :(

> DiskCache.3.Error
> DiskCache.3.DeleteFailed

that sgtm

[Ilya Sherman, 2014-08-19 22:34:36]

Please create a separate CL for migrating histograms out of the internal file
(which I agree should be done).

[michaeln, 2014-08-25 22:53:53]

On 2014/08/19 22:34:36, Ilya Sherman wrote:
> Please create a separate CL for migrating histograms out of the internal file
> (which I agree should be done).

i'm dropping this cl to create individual ones for related buckets, the first of
which is here: https://codereview.chromium.org/503873003/

[michaeln, 2014-08-26 19:52:26]

On 2014/08/25 22:53:53, michaeln wrote:
> On 2014/08/19 22:34:36, Ilya Sherman wrote:
> > Please create a separate CL for migrating histograms out of the internal
file
> > (which I agree should be done).
> 
> i'm dropping this cl to create individual ones for related buckets, the first
of
> which is here: https://codereview.chromium.org/503873003/

i'm not going to move the diskcache entries, i'll claim those i'm interested in
over in the internal file