Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 482853002: Remove gpu_feature_browsertest.cc (Closed)

Created:
6 years, 4 months ago by Zhenyao Mo
Modified:
6 years, 4 months ago
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove gpu_feature_browsertest.cc This test just causes too much trouble for us in the past, and what it tests should be covered in other tests already. BUG=314745 TEST=bots R=kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290595

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -505 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/gpu/gpu_feature_browsertest.cc View 1 chunk +0 lines, -500 lines 0 comments Download
M content/common/gpu/image_transport_surface_fbo_mac.mm View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Zhenyao Mo
Please take a look.
6 years, 4 months ago (2014-08-18 18:02:55 UTC) #1
jam
drive-by: please remove any methods from the content API that this was the only caller ...
6 years, 4 months ago (2014-08-18 18:17:25 UTC) #2
Zhenyao Mo
On 2014/08/18 18:17:25, jam wrote: > drive-by: please remove any methods from the content API ...
6 years, 4 months ago (2014-08-18 18:19:22 UTC) #3
Ken Russell (switch to Gerrit)
LGTM. As you point out, this test is running in a different form at this ...
6 years, 4 months ago (2014-08-18 20:39:44 UTC) #4
Zhenyao Mo
Unfortunately CanUseGpuBrowserCompositor is also used by wrench_menu_model: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/toolbar/wrench_menu_model.cc&l=573 Besides that, I don't see any other ...
6 years, 4 months ago (2014-08-18 22:42:10 UTC) #5
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 4 months ago (2014-08-18 22:42:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/482853002/1
6 years, 4 months ago (2014-08-18 22:43:11 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-18 23:01:07 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-18 23:22:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/41228)
6 years, 4 months ago (2014-08-18 23:22:07 UTC) #10
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 4 months ago (2014-08-19 16:08:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/482853002/1
6 years, 4 months ago (2014-08-19 16:11:46 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 16:55:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (1) as 290595

Powered by Google App Engine
This is Rietveld 408576698