Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: build/common.gypi

Issue 482733002: clang/win: Disable -Wexit-time-destructors for now, 2nd try. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 81ef8ece00a92691cd500949e5d721f5547846c6..6ded414512712e88be1400724b4a8a595c563407 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2936,7 +2936,8 @@
['<(chromeos)==1 and >(nacl_untrusted_build)==0', {
'defines': ['OS_CHROMEOS=1'],
}],
- ['enable_wexit_time_destructors==1', {
+ ['enable_wexit_time_destructors==1 and OS!="win"', {
+ # TODO: Enable on Windows too, http://crbug.com/404525
'variables': { 'clang_warning_flags': ['-Wexit-time-destructors']},
}],
['chromium_code==0', {
@@ -5406,7 +5407,6 @@
'-Wno-unused-private-field',
'-Wno-unused-value',
'-Wno-unused-variable',
- '-Wno-exit-time-destructors', # TODO: http://crbug.com/404525
'-ferror-limit=1',
],
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698