Move MediaPlayer, IntSizeHash to platform/

Move MediaPlayer, IntSizeHash to platform/

BUG=297477
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161359

[rwlbuis, 2013-10-29 22:44:12]

More misc stuff to move out of core/platform/graphics. After this I think we can
tackle the big move in core/platform/graphics.

[Stephen Chennney, 2013-10-29 23:50:59]

I thought maybe there was enough stuff to justify a media directory under
graphics, or even under platform/media. Does that seem possible to you? e.g.
InbandTextTrack, and the content decoding classes.

[rwlbuis, 2013-10-30 00:40:23]

On 2013/10/29 23:50:59, Stephen Chenney wrote:
> I thought maybe there was enough stuff to justify a media directory under
> graphics, or even under platform/media. Does that seem possible to you? e.g.
> InbandTextTrack, and the content decoding classes.

Yes, I was thinking about that too, sure I can do a new changeset for this issue
tomorrow.

[philipj_slow, 2013-10-30 12:52:25]

Note that Aaron Colwell has asked me to get rid of MediaPlayer and letting
HTMLMediaElement talk to WebMediaPlayer directly:
https://code.google.com/p/chromium/issues/detail?id=310466

(I have no objections to this move thought.)

[rwlbuis, 2013-10-30 14:56:50]

On 2013/10/29 23:50:59, Stephen Chenney wrote:
> I thought maybe there was enough stuff to justify a media directory under
> graphics, or even under platform/media. Does that seem possible to you? e.g.
> InbandTextTrack, and the content decoding classes.

Great suggestion, I chose platform/graphics/media in my latest changeset. This
makes me think that later we also may want to go for platform/graphics/image or
platform/image since we have quite some image related classes.

[rwlbuis, 2013-10-30 14:57:32]

Also move ContentDecryptionModule stuff and introduce platform/graphics/media.

[Stephen Chennney, 2013-10-30 16:03:15]

One nit to fix before commit. Otherwise LGTM.

https://codereview.chromium.org/48273013/diff/70001/Source/platform/blink_pla...
File Source/platform/blink_platform.gypi (right):

https://codereview.chromium.org/48273013/diff/70001/Source/platform/blink_pla...
Source/platform/blink_platform.gypi:298:
'graphics/media/InbandTextTrackPrivateClient.h',
Add IntSizeHash.h here too. It is used in generating the file lists for Visual
Studio projects, which benefits our Windows developers.

[rwlbuis, 2013-10-30 16:13:57]

https://codereview.chromium.org/48273013/diff/70001/Source/platform/blink_pla...
File Source/platform/blink_platform.gypi (right):

https://codereview.chromium.org/48273013/diff/70001/Source/platform/blink_pla...
Source/platform/blink_platform.gypi:298:
'graphics/media/InbandTextTrackPrivateClient.h',
On 2013/10/30 16:03:16, Stephen Chenney wrote:
> Add IntSizeHash.h here too. It is used in generating the file lists for Visual
> Studio projects, which benefits our Windows developers.

Done.

[commit-bot: I haz the power, 2013-10-30 16:14:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/48273013/140001

[commit-bot: I haz the power, 2013-10-30 16:33:19]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[acolwell GONE FROM CHROMIUM, 2013-10-30 17:22:17]

On 2013/10/30 14:56:50, rwlbuis wrote:
> On 2013/10/29 23:50:59, Stephen Chenney wrote:
> > I thought maybe there was enough stuff to justify a media directory under
> > graphics, or even under platform/media. Does that seem possible to you? e.g.
> > InbandTextTrack, and the content decoding classes.
> 
> Great suggestion, I chose platform/graphics/media in my latest changeset. This
> makes me think that later we also may want to go for platform/graphics/image
or
> platform/image since we have quite some image related classes.

I'm fine with this media directory being created for now. MediaPlayer and
InbandTextTrackPrivateXXX will likely be removed since they are mostly pass-thru
objects left over from WebKit days. ddorwin@ can comment on whether he plans on
eventually removing the ContentDecryptionXXX stuff.

[rwlbuis, 2013-10-30 17:47:18]

On 2013/10/30 16:33:19, I haz the power (commit-bot) wrote:
> Retried try job too often on blink_presubmit for step(s) presubmit
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

Sorry for that, I assumed that one lgtm was enough but actually my interface is
indicating permission from owners for the v8, web and modules parts are needed.

[ddorwin, 2013-10-30 18:02:34]

On 2013/10/30 17:22:17, acolwell wrote:
> On 2013/10/30 14:56:50, rwlbuis wrote:
> > On 2013/10/29 23:50:59, Stephen Chenney wrote:
> > > I thought maybe there was enough stuff to justify a media directory under
> > > graphics, or even under platform/media. Does that seem possible to you?
e.g.
> > > InbandTextTrack, and the content decoding classes.
> > 
> > Great suggestion, I chose platform/graphics/media in my latest changeset.
This
> > makes me think that later we also may want to go for platform/graphics/image
> or
> > platform/image since we have quite some image related classes.
> 
> I'm fine with this media directory being created for now. MediaPlayer and
> InbandTextTrackPrivateXXX will likely be removed since they are mostly
pass-thru
> objects left over from WebKit days. ddorwin@ can comment on whether he plans
on
> eventually removing the ContentDecryptionXXX stuff.

It looks like ContentDecryptionXXX stuff could be eliminated in favor of
Source/modules/encryptedmedia/ using public/platform/ directly.

[rwlbuis, 2013-10-31 21:23:02]

Rebased against ToT.

[abarth-chromium, 2013-11-05 16:19:34]

rsLGTM assuming schenney is happy

[Stephen Chennney, 2013-11-05 16:24:22]

LGTM. Go for it.

[commit-bot: I haz the power, 2013-11-05 16:51:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/48273013/310001

[commit-bot: I haz the power, 2013-11-05 17:11:53]

Retried try job too often on linux_blink_rel for step(s) webkit_lint,
webkit_python_tests, webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2013-11-05 17:25:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/48273013/310001

[commit-bot: I haz the power, 2013-11-05 20:28:31]

Change committed as 161359