Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 48273011: Fix pipe/annotation. (Closed)

Created:
7 years, 1 month ago by mtklein
Modified:
7 years, 1 month ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com, reed1, epoger
Visibility:
Public.

Description

Fix pipe/annotation. We weren't keeping track of the annotation that's on the other side of the pipe. BUG=skia:1761 Committed: http://code.google.com/p/skia/source/detail?r=12004

Patch Set 1 #

Total comments: 2

Patch Set 2 : after #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M gm/internal_links.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
7 years, 1 month ago (2013-10-29 19:03:13 UTC) #1
scroggo
lgtm https://codereview.chromium.org/48273011/diff/1/src/pipe/SkGPipeWrite.cpp File src/pipe/SkGPipeWrite.cpp (right): https://codereview.chromium.org/48273011/diff/1/src/pipe/SkGPipeWrite.cpp#newcode1130 src/pipe/SkGPipeWrite.cpp:1130: base.setAnnotation(paint.getAnnotation()); nit: The other cases all modify base ...
7 years, 1 month ago (2013-10-29 19:06:04 UTC) #2
mtklein
https://codereview.chromium.org/48273011/diff/1/src/pipe/SkGPipeWrite.cpp File src/pipe/SkGPipeWrite.cpp (right): https://codereview.chromium.org/48273011/diff/1/src/pipe/SkGPipeWrite.cpp#newcode1130 src/pipe/SkGPipeWrite.cpp:1130: base.setAnnotation(paint.getAnnotation()); On 2013/10/29 19:06:04, scroggo wrote: > nit: The ...
7 years, 1 month ago (2013-10-29 19:11:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/48273011/60001
7 years, 1 month ago (2013-10-29 19:11:47 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-10-29 19:23:29 UTC) #5
Message was sent while issue was closed.
Change committed as 12004

Powered by Google App Engine
This is Rietveld 408576698