Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 48273007: Polling the server upon receiving push messages (Closed)

Created:
7 years, 1 month ago by vadimt
Modified:
7 years, 1 month ago
Reviewers:
robliao, rgustafson, skare_
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Polling the server upon receiving push messages. Creating a general mechanism for this. BUG=164227 TEST=No Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231712

Patch Set 1 #

Patch Set 2 : Cosmetics #

Total comments: 6

Patch Set 3 : CR comments #

Total comments: 6

Patch Set 4 : robliao@ comments. #

Total comments: 2

Patch Set 5 : More comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M chrome/browser/resources/google_now/background.js View 1 2 3 4 2 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
vadimt
7 years, 1 month ago (2013-10-28 22:48:54 UTC) #1
robliao
https://codereview.chromium.org/48273007/diff/30001/chrome/browser/resources/google_now/background.js File chrome/browser/resources/google_now/background.js (right): https://codereview.chromium.org/48273007/diff/30001/chrome/browser/resources/google_now/background.js#newcode1061 chrome/browser/resources/google_now/background.js:1061: chrome.storage.local.set( Can this be abused? If pushMessaging for some ...
7 years, 1 month ago (2013-10-28 22:54:49 UTC) #2
vadimt
https://codereview.chromium.org/48273007/diff/30001/chrome/browser/resources/google_now/background.js File chrome/browser/resources/google_now/background.js (right): https://codereview.chromium.org/48273007/diff/30001/chrome/browser/resources/google_now/background.js#newcode1061 chrome/browser/resources/google_now/background.js:1061: chrome.storage.local.set( On 2013/10/28 22:54:50, Robert Liao wrote: > Can ...
7 years, 1 month ago (2013-10-28 23:01:10 UTC) #3
robliao
https://codereview.chromium.org/48273007/diff/30001/chrome/browser/resources/google_now/background.js File chrome/browser/resources/google_now/background.js (right): https://codereview.chromium.org/48273007/diff/30001/chrome/browser/resources/google_now/background.js#newcode1061 chrome/browser/resources/google_now/background.js:1061: chrome.storage.local.set( Can we narrow the scope down? We may ...
7 years, 1 month ago (2013-10-28 23:43:37 UTC) #4
skare_
https://codereview.chromium.org/48273007/diff/30001/chrome/browser/resources/google_now/background.js File chrome/browser/resources/google_now/background.js (right): https://codereview.chromium.org/48273007/diff/30001/chrome/browser/resources/google_now/background.js#newcode1061 chrome/browser/resources/google_now/background.js:1061: chrome.storage.local.set( On 2013/10/28 23:43:37, Robert Liao wrote: > Can ...
7 years, 1 month ago (2013-10-28 23:50:24 UTC) #5
vadimt
> Can we narrow the scope down? We may not want all push messages in ...
7 years, 1 month ago (2013-10-29 00:40:47 UTC) #6
robliao
https://codereview.chromium.org/48273007/diff/30001/chrome/browser/resources/google_now/background.js File chrome/browser/resources/google_now/background.js (right): https://codereview.chromium.org/48273007/diff/30001/chrome/browser/resources/google_now/background.js#newcode1061 chrome/browser/resources/google_now/background.js:1061: chrome.storage.local.set( As discussed in the email, a known payload ...
7 years, 1 month ago (2013-10-29 01:03:52 UTC) #7
rgustafson
https://codereview.chromium.org/48273007/diff/30001/chrome/browser/resources/google_now/background.js File chrome/browser/resources/google_now/background.js (right): https://codereview.chromium.org/48273007/diff/30001/chrome/browser/resources/google_now/background.js#newcode1061 chrome/browser/resources/google_now/background.js:1061: chrome.storage.local.set( On 2013/10/28 23:50:24, Travis Skare wrote: > On ...
7 years, 1 month ago (2013-10-29 01:09:25 UTC) #8
vadimt
Looks like everyone would be happy if I checked payloads. Doing do.
7 years, 1 month ago (2013-10-29 02:05:36 UTC) #9
robliao
https://codereview.chromium.org/48273007/diff/140001/chrome/browser/resources/google_now/background.js File chrome/browser/resources/google_now/background.js (right): https://codereview.chromium.org/48273007/diff/140001/chrome/browser/resources/google_now/background.js#newcode1088 chrome/browser/resources/google_now/background.js:1088: items.lastPollNowPayloads = items.lastPollNowPayloads || {}; The previous CR expressed ...
7 years, 1 month ago (2013-10-29 02:25:19 UTC) #10
vadimt
https://codereview.chromium.org/48273007/diff/140001/chrome/browser/resources/google_now/background.js File chrome/browser/resources/google_now/background.js (right): https://codereview.chromium.org/48273007/diff/140001/chrome/browser/resources/google_now/background.js#newcode1088 chrome/browser/resources/google_now/background.js:1088: items.lastPollNowPayloads = items.lastPollNowPayloads || {}; On 2013/10/29 02:25:20, Robert ...
7 years, 1 month ago (2013-10-29 02:55:18 UTC) #11
robliao
https://codereview.chromium.org/48273007/diff/140001/chrome/browser/resources/google_now/background.js File chrome/browser/resources/google_now/background.js (right): https://codereview.chromium.org/48273007/diff/140001/chrome/browser/resources/google_now/background.js#newcode1088 chrome/browser/resources/google_now/background.js:1088: items.lastPollNowPayloads = items.lastPollNowPayloads || {}; Most of the code ...
7 years, 1 month ago (2013-10-29 17:06:30 UTC) #12
vadimt
https://codereview.chromium.org/48273007/diff/140001/chrome/browser/resources/google_now/background.js File chrome/browser/resources/google_now/background.js (right): https://codereview.chromium.org/48273007/diff/140001/chrome/browser/resources/google_now/background.js#newcode1088 chrome/browser/resources/google_now/background.js:1088: items.lastPollNowPayloads = items.lastPollNowPayloads || {}; On 2013/10/29 17:06:30, Robert ...
7 years, 1 month ago (2013-10-29 17:46:30 UTC) #13
robliao
https://codereview.chromium.org/48273007/diff/140001/chrome/browser/resources/google_now/background.js File chrome/browser/resources/google_now/background.js (right): https://codereview.chromium.org/48273007/diff/140001/chrome/browser/resources/google_now/background.js#newcode1088 chrome/browser/resources/google_now/background.js:1088: items.lastPollNowPayloads = items.lastPollNowPayloads || {}; It's worth adding some ...
7 years, 1 month ago (2013-10-29 17:56:58 UTC) #14
vadimt
https://codereview.chromium.org/48273007/diff/140001/chrome/browser/resources/google_now/background.js File chrome/browser/resources/google_now/background.js (right): https://codereview.chromium.org/48273007/diff/140001/chrome/browser/resources/google_now/background.js#newcode1088 chrome/browser/resources/google_now/background.js:1088: items.lastPollNowPayloads = items.lastPollNowPayloads || {}; On 2013/10/29 17:56:59, Robert ...
7 years, 1 month ago (2013-10-29 18:06:35 UTC) #15
robliao
LGTM with one comment. https://codereview.chromium.org/48273007/diff/230001/chrome/browser/resources/google_now/background.js File chrome/browser/resources/google_now/background.js (right): https://codereview.chromium.org/48273007/diff/230001/chrome/browser/resources/google_now/background.js#newcode1086 chrome/browser/resources/google_now/background.js:1086: // If storage.get fails, it's ...
7 years, 1 month ago (2013-10-29 18:09:41 UTC) #16
vadimt
https://codereview.chromium.org/48273007/diff/230001/chrome/browser/resources/google_now/background.js File chrome/browser/resources/google_now/background.js (right): https://codereview.chromium.org/48273007/diff/230001/chrome/browser/resources/google_now/background.js#newcode1086 chrome/browser/resources/google_now/background.js:1086: // If storage.get fails, it's safer to do nothing. ...
7 years, 1 month ago (2013-10-29 18:14:15 UTC) #17
rgustafson
lgtm
7 years, 1 month ago (2013-10-29 19:46:17 UTC) #18
skare_
lgtm
7 years, 1 month ago (2013-10-29 19:50:53 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimt@chromium.org/48273007/280001
7 years, 1 month ago (2013-10-29 20:03:20 UTC) #20
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 02:00:42 UTC) #21
Message was sent while issue was closed.
Change committed as 231712

Powered by Google App Engine
This is Rietveld 408576698