content/browser/renderer_host/input/touch_selection_controller.cc - Issue 482723002: Do not hide the selection handles on tap event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/touch_selection_controller.cc

Issue 482723002: Do not hide the selection handles on tap event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added unit test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/input/touch_selection_controller.cc

diff --git a/content/browser/renderer_host/input/touch_selection_controller.cc b/content/browser/renderer_host/input/touch_selection_controller.cc

index d5380487e255bb339823fe0b39f112633f0d2ce6..7867b5afa1d8d7a39195f1374124516afff7e5c4 100644

--- a/content/browser/renderer_host/input/touch_selection_controller.cc

+++ b/content/browser/renderer_host/input/touch_selection_controller.cc

@@ -137,8 +137,6 @@ void TouchSelectionController::OnLongPressEvent() {

void TouchSelectionController::OnTapEvent() {

response_pending_input_event_ = TAP;

- activate_selection_automatically_ = false;

- DeactivateSelection();

ShowInsertionHandleAutomatically();

ResetCachedValuesIfInactive();

}