Do not hide the selection handles on tap event

Do not hide the selection handles on tap event

Currently selection handles are being hidden on tap event. But in case
of tapping on image, the selection doesnt get cleared and we dont
receive any bounds changed message from blink, hence selection stays
but the handles are hidden. Hiding the handles on tap event is not
necessary as it is already handled when the selection bounds change

BUG=404625
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290814

[raghu, 2014-08-18 13:27:15]

Hi Jdduke,

Deactivating the Selection is already handled through OnSelectionBoundsChanged.
In my opinion we dont need to additionaly do it in OnTapEvent.

PTAL.

[jdduke (slow), 2014-08-18 14:53:57]

Could you add a test for this behavior (having an active selection, then
tapping, then ensuring the selection is updated properly when it changes)?
Thanks.

[raghu, 2014-08-19 08:54:14]

On 2014/08/18 14:53:57, jdduke wrote:
> Could you add a test for this behavior (having an active selection, then
> tapping, then ensuring the selection is updated properly when it changes)?
> Thanks.

I have added a unit test for this. PTAL

[jdduke (slow), 2014-08-20 01:50:53]

lgtm with nit.

https://codereview.chromium.org/482723002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/input/touch_selection_controller_unittest.cc
(right):

https://codereview.chromium.org/482723002/diff/20001/content/browser/renderer...
content/browser/renderer_host/input/touch_selection_controller_unittest.cc:659:
// Selection should not be cleared if the selection bounds have not changed
Nit: period at end of comments (line break if necessary can't tell if this is
already 80 characters wide).

[raghu, 2014-08-20 05:02:10]

Thanks

https://codereview.chromium.org/482723002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/input/touch_selection_controller_unittest.cc
(right):

https://codereview.chromium.org/482723002/diff/20001/content/browser/renderer...
content/browser/renderer_host/input/touch_selection_controller_unittest.cc:659:
// Selection should not be cleared if the selection bounds have not changed
On 2014/08/20 01:50:53, jdduke wrote:
> Nit: period at end of comments (line break if necessary can't tell if this is
> already 80 characters wide).

Done.

[raghu, 2014-08-20 05:03:46]

The CQ bit was checked by r.ghatage@samsung.com

[commit-bot: I haz the power, 2014-08-20 05:04:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/482723002/40001

[commit-bot: I haz the power, 2014-08-20 05:12:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/43985)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/49153)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-20 05:14:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-20 05:14:28]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/43986)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[raghu, 2014-08-20 08:20:55]

The CQ bit was checked by r.ghatage@samsung.com

[commit-bot: I haz the power, 2014-08-20 08:22:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/482723002/60001

[commit-bot: I haz the power, 2014-08-20 10:00:12]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-20 11:48:03]

Committed patchset #4 (60001) as 290814