Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 482643004: Fix a trio of autofill popup issues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/autofill_agent.cc
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc
index ab9bfae2cc956d59d0b93a3ca2b35b0ef60aa9d9..82c0867d9018b59eb5bc10468acb1e4a0ec12745 100644
--- a/components/autofill/content/renderer/autofill_agent.cc
+++ b/components/autofill/content/renderer/autofill_agent.cc
@@ -221,7 +221,6 @@ void AutofillAgent::FocusedNodeChanged(const WebNode& node) {
if (password_generation_agent_ &&
password_generation_agent_->FocusedNodeHasChanged(node)) {
- is_popup_possibly_visible_ = true;
return;
}
@@ -246,6 +245,10 @@ void AutofillAgent::OrientationChangeEvent() {
HidePopup();
}
+void AutofillAgent::Resized() {
+ HidePopup();
+}
+
void AutofillAgent::DidChangeScrollOffset(WebLocalFrame*) {
HidePopup();
}
@@ -363,7 +366,6 @@ void AutofillAgent::TextFieldDidChangeImpl(
if (input_element) {
if (password_generation_agent_ &&
password_generation_agent_->TextDidChangeInTextField(*input_element)) {
- is_popup_possibly_visible_ = true;
return;
}
@@ -571,6 +573,8 @@ void AutofillAgent::ShowSuggestions(const WebFormControlElement& element,
return;
}
+ is_popup_possibly_visible_ = true;
+
// Don't attempt to autofill with values that are too large or if filling
// criteria are not met.
WebString value = element.editingValue();
@@ -590,7 +594,6 @@ void AutofillAgent::ShowSuggestions(const WebFormControlElement& element,
(password_autofill_agent_->ShowSuggestions(*input_element,
show_full_suggestion_list) ||
show_password_suggestions_only)) {
- is_popup_possibly_visible_ = true;
return;
}
@@ -657,7 +660,6 @@ void AutofillAgent::QueryAutofillSuggestions(
TrimStringVectorForIPC(&data_list_labels);
}
- is_popup_possibly_visible_ = true;
Send(new AutofillHostMsg_SetDataList(routing_id(),
data_list_values,
data_list_labels));

Powered by Google App Engine
This is Rietveld 408576698