list apis by channel info, e.g. dev, stable

chrome/common/extensions/docs/server2/api_models.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 import posixpath
 
 from compiled_file_system import SingleFile
 from file_system import FileNotFoundError
 from future import Gettable, Future
 from schema_util import ProcessSchema
 from svn_constants import API_PATH
 from third_party.json_schema_compiler.model import Namespace, UnixName
 
 
 @SingleFile
 def _CreateAPIModel(path, data):
   schema = ProcessSchema(path, data)
   if os.path.splitext(path)[1] == '.json':
     schema = schema[0]
+  if not schema: return None

[not at google - send to devlin, 2013/11/07 23:52:18]

When does this happen? If the schema doesn't parse or something? Is there any
chance we can not make this change? I don't like guarding against buggy
behaviour elsewhere in the system.

[hukun, 2013/11/08 06:23:39]

One example is "musicManagerPrivate". 

1) ProcessSchema will return None, so scheme is None. But, use
schema['namespace'] will throw exceptio due to None ref

2) Inside ProcessSchema, RemoveNoDocs is called. By design, RemoveNoDocs will
return true due to "[nodoc]" element.

So, I am not sure if it is by design or buggy. I would like to help fix this
issue if need. 

Listen to your opinion to go ahead.

   return Namespace(schema, schema['namespace'])
 
-

[not at google - send to devlin, 2013/11/07 23:52:18]

Ppython style is still is actually to have 2 blank lines between top-level
classes/functions, not 1.

I didn't realise this for a while which is why a lot of existing code doesn't
follow it.

[hukun, 2013/11/08 06:23:39]

Done

 class APIModels(object):
   '''Tracks APIs and their Models.
   '''
 
   def __init__(self, features_bundle, compiled_fs_factory, file_system):
     self._features_bundle = features_bundle
     self._model_cache = compiled_fs_factory.Create(
         file_system, _CreateAPIModel, APIModels)
 
   def GetNames(self):
@@ skipping 31 matching lines @@
                                              (API_PATH, file_name, ext))
                for ext in ('json', 'idl')]
     def resolve():
       for future in futures:
         try:
           return future.Get()
         except FileNotFoundError: pass
       # Propagate the first FileNotFoundError if neither were found.
       futures[0].Get()
     return Future(delegate=Gettable(resolve))